Google Git
Sign in
dawn/dawn/3f908f3907e532481e4c91d3b814b46869405fe8
commit
3f908f3907e532481e4c91d3b814b46869405fe8
[log]
author
Jiawei Shao <jiawei.shao@intel.com>
Sun Jan 05 19:27:43 2025 -0800
committer
Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sun Jan 05 19:27:43 2025 -0800
tree
4f4bc1a5b04c73f7d1ea479019b16c26f26c66c8
parent
28858cfac0b9028bc69a27e17c0bb85cf01441f1 [diff]
Fix crash when calling `GetBindGroupLayout()` on null bindGroupLayout

This patch fixes a crash issue when calling `GetBindGroupLayout()` on a
null bind group layout item in the pipeline layout used to create the
pipeline. According to the latest WebGPU SPEC, the parameter `index` is
valid as long as `index < the size of this.[[layout]].[[bindGroupLayouts]]`,
so calling `GetBindGroupLayout()` on a null bind group layout item in the
pipeline layout should be legal and return an empty bind group layout.

Bug: 377836524, 42241530
Test: dawn_unittests
Change-Id: I57bc9a136e3da01e8442f6752c98bfa09eef6f2f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/220455
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
4 files changed
tree: 4f4bc1a5b04c73f7d1ea479019b16c26f26c66c8
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. AUTHORS
  26. BUILD.bazel
  27. BUILD.gn
  28. CMakeLists.txt
  29. CMakeSettings.json
  30. CODE_OF_CONDUCT.md
  31. codereview.settings
  32. CONTRIBUTING.md
  33. CPPLINT.cfg
  34. DEPS
  35. DIR_METADATA
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. WATCHLISTS
  45. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.