| commit | fab9a5fd8160138eea5035c626d7e739cb4c9ea9 | [log] [tgz] |
|---|---|---|
| author | dan sinclair <dsinclair@chromium.org> | Tue Jan 28 09:50:06 2025 -0800 |
| committer | Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jan 28 09:50:06 2025 -0800 |
| tree | 6d189e7301ca1f9984ea8cfe67abac1935a2746b | |
| parent | 2c522ae8e237d1d2c3766a8c7a1af23d4ff05d4d [diff] |
[inspector] Fix issue with finding texture,sampler pairs.
When looking for the entry points associated to samplers and textures
we'd find the calls which used a sampler, and then add any entry point
which was reachable up the call chain from that usage.
This is incorrect in the face of a forked call pattern:
```
s
/ \
/ \
/ \
s(t0, s0) s(t1, s0)
/ \
vert frag
```
In this case, we'd associate both `t0,s0` and `t1,s0` to both the vertex
and fragment shaders. Instead, we should only associate `t0,s0` to the
vertex shader and `t1,s0` to the fragment shader.
This Cl changes the routine such that instead of getting the entry
points early it waits until we've found both the texture and sampler in
the call stack and uses that function as the basis for determining the
entry points.
Bug: 380433758
Change-Id: Ibe313404417ba77a0ed5467c4d1b20f188fe47a6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/223534
Reviewed-by: David Neto <dneto@google.com>
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.
Dawn provides several WebGPU building blocks:
webgpu.h version that Dawn implements.webgpu.h.Helpful links:
Developer documentation:
User documentation: (TODO, figure out what overlaps with the webgpu.h docs)
BSD 3-Clause License, please see LICENSE.
This is not an officially supported Google product.