Update gn_v2 MSVC GN args and tests Updates the gn_v2 MSVC builder to build non-component builds without SwiftShader. The compile failures we have been seeing are caused by building the `default` target with component builds. SwiftShader may run into issues on non-component builds due to frequent loading/unloading of the library. We will see if Dawn tests run into any such issues, and if so, `dawn_use_swiftshader` will be disabled and relevant tests removed in a follow-up. Bug: 385317083 Change-Id: Ic35c19b915450310dddb1a3cdb2c97619ca15039 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/265040 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@google.com>
diff --git a/infra/config/global/generated/builders/ci/dawn-win-x64-builder-msvc-rel/gn-args.json b/infra/config/global/generated/builders/ci/dawn-win-x64-builder-msvc-rel/gn-args.json index a894494..27ba984 100644 --- a/infra/config/global/generated/builders/ci/dawn-win-x64-builder-msvc-rel/gn-args.json +++ b/infra/config/global/generated/builders/ci/dawn-win-x64-builder-msvc-rel/gn-args.json
@@ -3,7 +3,7 @@ "dawn_build_node_bindings": true, "dawn_use_swiftshader": true, "is_clang": false, - "is_component_build": true, + "is_component_build": false, "is_debug": false, "target_cpu": "x64", "target_os": "win",
diff --git a/infra/config/global/generated/builders/try/dawn-try-win-x64-sws-msvc-rel/gn-args.json b/infra/config/global/generated/builders/try/dawn-try-win-x64-sws-msvc-rel/gn-args.json index a894494..27ba984 100644 --- a/infra/config/global/generated/builders/try/dawn-try-win-x64-sws-msvc-rel/gn-args.json +++ b/infra/config/global/generated/builders/try/dawn-try-win-x64-sws-msvc-rel/gn-args.json
@@ -3,7 +3,7 @@ "dawn_build_node_bindings": true, "dawn_use_swiftshader": true, "is_clang": false, - "is_component_build": true, + "is_component_build": false, "is_debug": false, "target_cpu": "x64", "target_os": "win",
diff --git a/infra/config/global/gn_args.star b/infra/config/global/gn_args.star index e5d48cf..5ff92a1 100644 --- a/infra/config/global/gn_args.star +++ b/infra/config/global/gn_args.star
@@ -51,6 +51,13 @@ ) gn_args.config( + name = "dawn_no_swiftshader", + args = { + "dawn_use_swiftshader": False, + }, +) + +gn_args.config( name = "dawn_node_bindings", args = { "dawn_build_node_bindings": True,
diff --git a/infra/config/global/gn_standalone_ci.star b/infra/config/global/gn_standalone_ci.star index f8d2549..4c9f72c 100644 --- a/infra/config/global/gn_standalone_ci.star +++ b/infra/config/global/gn_standalone_ci.star
@@ -336,9 +336,11 @@ ), gn_args = gn_args.config( configs = [ - "component", + # Component builds cause compile failures for the `default` target + # with MSVC, so use non_component. See crbug.com/449779009. "dawn_node_bindings", "dawn_swiftshader", + "non_component", "release", "win_msvc", "x64",