| // Copyright 2017 The Dawn Authors |
| // |
| // Licensed under the Apache License, Version 2.0 (the "License"); |
| // you may not use this file except in compliance with the License. |
| // You may obtain a copy of the License at |
| // |
| // http://www.apache.org/licenses/LICENSE-2.0 |
| // |
| // Unless required by applicable law or agreed to in writing, software |
| // distributed under the License is distributed on an "AS IS" BASIS, |
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| // See the License for the specific language governing permissions and |
| // limitations under the License. |
| |
| #include "tests/unittests/validation/ValidationTest.h" |
| |
| #include "common/Constants.h" |
| #include "utils/ComboRenderPipelineDescriptor.h" |
| #include "utils/DawnHelpers.h" |
| |
| class BindGroupValidationTest : public ValidationTest { |
| public: |
| void SetUp() override { |
| // Create objects to use as resources inside test bind groups. |
| { |
| dawn::BufferDescriptor descriptor; |
| descriptor.size = 1024; |
| descriptor.usage = dawn::BufferUsage::Uniform; |
| mUBO = device.CreateBuffer(&descriptor); |
| } |
| { |
| dawn::BufferDescriptor descriptor; |
| descriptor.size = 1024; |
| descriptor.usage = dawn::BufferUsage::Storage; |
| mSSBO = device.CreateBuffer(&descriptor); |
| } |
| { |
| dawn::SamplerDescriptor descriptor = utils::GetDefaultSamplerDescriptor(); |
| mSampler = device.CreateSampler(&descriptor); |
| } |
| { |
| dawn::TextureDescriptor descriptor; |
| descriptor.dimension = dawn::TextureDimension::e2D; |
| descriptor.size = {16, 16, 1}; |
| descriptor.arrayLayerCount = 1; |
| descriptor.sampleCount = 1; |
| descriptor.format = dawn::TextureFormat::RGBA8Unorm; |
| descriptor.mipLevelCount = 1; |
| descriptor.usage = dawn::TextureUsage::Sampled; |
| mSampledTexture = device.CreateTexture(&descriptor); |
| mSampledTextureView = mSampledTexture.CreateView(); |
| } |
| } |
| |
| protected: |
| dawn::Buffer mUBO; |
| dawn::Buffer mSSBO; |
| dawn::Sampler mSampler; |
| dawn::Texture mSampledTexture; |
| dawn::TextureView mSampledTextureView; |
| }; |
| |
| // Test the validation of BindGroupDescriptor::nextInChain |
| TEST_F(BindGroupValidationTest, NextInChainNullptr) { |
| dawn::BindGroupLayout layout = utils::MakeBindGroupLayout(device, {}); |
| |
| dawn::BindGroupDescriptor descriptor; |
| descriptor.layout = layout; |
| descriptor.bindingCount = 0; |
| descriptor.bindings = nullptr; |
| |
| // Control case: check that nextInChain = nullptr is valid |
| descriptor.nextInChain = nullptr; |
| device.CreateBindGroup(&descriptor); |
| |
| // Check that nextInChain != nullptr is an error. |
| descriptor.nextInChain = static_cast<void*>(&descriptor); |
| ASSERT_DEVICE_ERROR(device.CreateBindGroup(&descriptor)); |
| } |
| |
| // Check constraints on bindingCount |
| TEST_F(BindGroupValidationTest, bindingCountMismatch) { |
| dawn::BindGroupLayout layout = utils::MakeBindGroupLayout( |
| device, {{0, dawn::ShaderStage::Fragment, dawn::BindingType::Sampler}}); |
| |
| // Control case: check that a descriptor with one binding is ok |
| utils::MakeBindGroup(device, layout, {{0, mSampler}}); |
| |
| // Check that bindingCount != layout.bindingCount fails. |
| ASSERT_DEVICE_ERROR(utils::MakeBindGroup(device, layout, {})); |
| } |
| |
| // Check constraints on BindGroupBinding::binding |
| TEST_F(BindGroupValidationTest, WrongBindings) { |
| dawn::BindGroupLayout layout = utils::MakeBindGroupLayout( |
| device, {{0, dawn::ShaderStage::Fragment, dawn::BindingType::Sampler}}); |
| |
| // Control case: check that a descriptor with a binding matching the layout's is ok |
| utils::MakeBindGroup(device, layout, {{0, mSampler}}); |
| |
| // Check that binding must be present in the layout |
| ASSERT_DEVICE_ERROR(utils::MakeBindGroup(device, layout, {{1, mSampler}})); |
| |
| // Check that binding >= kMaxBindingsPerGroup fails. |
| ASSERT_DEVICE_ERROR(utils::MakeBindGroup(device, layout, {{kMaxBindingsPerGroup, mSampler}})); |
| } |
| |
| // Check that the same binding cannot be set twice |
| TEST_F(BindGroupValidationTest, BindingSetTwice) { |
| dawn::BindGroupLayout layout = utils::MakeBindGroupLayout( |
| device, {{0, dawn::ShaderStage::Fragment, dawn::BindingType::Sampler}, |
| {1, dawn::ShaderStage::Fragment, dawn::BindingType::Sampler}}); |
| |
| // Control case: check that different bindings work |
| utils::MakeBindGroup(device, layout, { |
| {0, mSampler}, |
| {1, mSampler} |
| }); |
| |
| // Check that setting the same binding twice is invalid |
| ASSERT_DEVICE_ERROR(utils::MakeBindGroup(device, layout, { |
| {0, mSampler}, |
| {0, mSampler} |
| })); |
| } |
| |
| // Check that a sampler binding must contain exactly one sampler |
| TEST_F(BindGroupValidationTest, SamplerBindingType) { |
| dawn::BindGroupLayout layout = utils::MakeBindGroupLayout( |
| device, {{0, dawn::ShaderStage::Fragment, dawn::BindingType::Sampler}}); |
| |
| dawn::BindGroupBinding binding; |
| binding.binding = 0; |
| binding.sampler = nullptr; |
| binding.textureView = nullptr; |
| binding.buffer = nullptr; |
| binding.offset = 0; |
| binding.size = 0; |
| |
| dawn::BindGroupDescriptor descriptor; |
| descriptor.layout = layout; |
| descriptor.bindingCount = 1; |
| descriptor.bindings = &binding; |
| |
| // Not setting anything fails |
| ASSERT_DEVICE_ERROR(device.CreateBindGroup(&descriptor)); |
| |
| // Control case: setting just the sampler works |
| binding.sampler = mSampler; |
| device.CreateBindGroup(&descriptor); |
| |
| // Setting the texture view as well is an error |
| binding.textureView = mSampledTextureView; |
| ASSERT_DEVICE_ERROR(device.CreateBindGroup(&descriptor)); |
| binding.textureView = nullptr; |
| |
| // Setting the buffer as well is an error |
| binding.buffer = mUBO; |
| ASSERT_DEVICE_ERROR(device.CreateBindGroup(&descriptor)); |
| binding.buffer = nullptr; |
| |
| // Setting the sampler to an error sampler is an error. |
| { |
| dawn::SamplerDescriptor samplerDesc = utils::GetDefaultSamplerDescriptor(); |
| samplerDesc.minFilter = static_cast<dawn::FilterMode>(0xFFFFFFFF); |
| |
| dawn::Sampler errorSampler; |
| ASSERT_DEVICE_ERROR(errorSampler = device.CreateSampler(&samplerDesc)); |
| |
| binding.sampler = errorSampler; |
| ASSERT_DEVICE_ERROR(device.CreateBindGroup(&descriptor)); |
| binding.sampler = nullptr; |
| } |
| } |
| |
| // Check that a texture binding must contain exactly a texture view |
| TEST_F(BindGroupValidationTest, TextureBindingType) { |
| dawn::BindGroupLayout layout = utils::MakeBindGroupLayout( |
| device, {{0, dawn::ShaderStage::Fragment, dawn::BindingType::SampledTexture}}); |
| |
| dawn::BindGroupBinding binding; |
| binding.binding = 0; |
| binding.sampler = nullptr; |
| binding.textureView = nullptr; |
| binding.buffer = nullptr; |
| binding.offset = 0; |
| binding.size = 0; |
| |
| dawn::BindGroupDescriptor descriptor; |
| descriptor.layout = layout; |
| descriptor.bindingCount = 1; |
| descriptor.bindings = &binding; |
| |
| // Not setting anything fails |
| ASSERT_DEVICE_ERROR(device.CreateBindGroup(&descriptor)); |
| |
| // Control case: setting just the texture view works |
| binding.textureView = mSampledTextureView; |
| device.CreateBindGroup(&descriptor); |
| |
| // Setting the sampler as well is an error |
| binding.sampler = mSampler; |
| ASSERT_DEVICE_ERROR(device.CreateBindGroup(&descriptor)); |
| binding.textureView = nullptr; |
| |
| // Setting the buffer as well is an error |
| binding.buffer = mUBO; |
| ASSERT_DEVICE_ERROR(device.CreateBindGroup(&descriptor)); |
| binding.buffer = nullptr; |
| |
| // Setting the texture view to an error texture view is an error. |
| { |
| dawn::TextureViewDescriptor viewDesc; |
| viewDesc.format = dawn::TextureFormat::RGBA8Unorm; |
| viewDesc.dimension = dawn::TextureViewDimension::e2D; |
| viewDesc.baseMipLevel = 0; |
| viewDesc.mipLevelCount = 0; |
| viewDesc.baseArrayLayer = 0; |
| viewDesc.arrayLayerCount = 1000; |
| |
| dawn::TextureView errorView; |
| ASSERT_DEVICE_ERROR(errorView = mSampledTexture.CreateView(&viewDesc)); |
| |
| binding.textureView = errorView; |
| ASSERT_DEVICE_ERROR(device.CreateBindGroup(&descriptor)); |
| binding.textureView = nullptr; |
| } |
| } |
| |
| // Check that a buffer binding must contain exactly a buffer |
| TEST_F(BindGroupValidationTest, BufferBindingType) { |
| dawn::BindGroupLayout layout = utils::MakeBindGroupLayout( |
| device, {{0, dawn::ShaderStage::Fragment, dawn::BindingType::UniformBuffer}}); |
| |
| dawn::BindGroupBinding binding; |
| binding.binding = 0; |
| binding.sampler = nullptr; |
| binding.textureView = nullptr; |
| binding.buffer = nullptr; |
| binding.offset = 0; |
| binding.size = 0; |
| |
| dawn::BindGroupDescriptor descriptor; |
| descriptor.layout = layout; |
| descriptor.bindingCount = 1; |
| descriptor.bindings = &binding; |
| |
| // Not setting anything fails |
| ASSERT_DEVICE_ERROR(device.CreateBindGroup(&descriptor)); |
| |
| // Control case: setting just the buffer works |
| binding.buffer = mUBO; |
| device.CreateBindGroup(&descriptor); |
| |
| // Setting the texture view as well is an error |
| binding.textureView = mSampledTextureView; |
| ASSERT_DEVICE_ERROR(device.CreateBindGroup(&descriptor)); |
| binding.textureView = nullptr; |
| |
| // Setting the sampler as well is an error |
| binding.sampler = mSampler; |
| ASSERT_DEVICE_ERROR(device.CreateBindGroup(&descriptor)); |
| binding.sampler = nullptr; |
| |
| // Setting the buffer to an error buffer is an error. |
| { |
| dawn::BufferDescriptor bufferDesc; |
| bufferDesc.size = 1024; |
| bufferDesc.usage = static_cast<dawn::BufferUsage>(0xFFFFFFFF); |
| |
| dawn::Buffer errorBuffer; |
| ASSERT_DEVICE_ERROR(errorBuffer = device.CreateBuffer(&bufferDesc)); |
| |
| binding.buffer = errorBuffer; |
| ASSERT_DEVICE_ERROR(device.CreateBindGroup(&descriptor)); |
| binding.buffer = nullptr; |
| } |
| } |
| |
| // Check that a texture must have the correct usage |
| TEST_F(BindGroupValidationTest, TextureUsage) { |
| dawn::BindGroupLayout layout = utils::MakeBindGroupLayout( |
| device, {{0, dawn::ShaderStage::Fragment, dawn::BindingType::SampledTexture}}); |
| |
| // Control case: setting a sampleable texture view works. |
| utils::MakeBindGroup(device, layout, {{0, mSampledTextureView}}); |
| |
| // Make an output attachment texture and try to set it for a SampledTexture binding |
| dawn::TextureDescriptor descriptor; |
| descriptor.dimension = dawn::TextureDimension::e2D; |
| descriptor.size = {16, 16, 1}; |
| descriptor.arrayLayerCount = 1; |
| descriptor.sampleCount = 1; |
| descriptor.format = dawn::TextureFormat::RGBA8Unorm; |
| descriptor.mipLevelCount = 1; |
| descriptor.usage = dawn::TextureUsage::OutputAttachment; |
| dawn::Texture outputTexture = device.CreateTexture(&descriptor); |
| dawn::TextureView outputTextureView = outputTexture.CreateView(); |
| ASSERT_DEVICE_ERROR(utils::MakeBindGroup(device, layout, {{0, outputTextureView}})); |
| } |
| |
| // Check that a texture must have the correct component type |
| TEST_F(BindGroupValidationTest, TextureComponentType) { |
| dawn::BindGroupLayout layout = utils::MakeBindGroupLayout( |
| device, {{0, dawn::ShaderStage::Fragment, dawn::BindingType::SampledTexture, false, false, |
| dawn::TextureViewDimension::e2D, dawn::TextureComponentType::Float}}); |
| |
| // Control case: setting a Float typed texture view works. |
| utils::MakeBindGroup(device, layout, {{0, mSampledTextureView}}); |
| |
| // Make a Uint component typed texture and try to set it to a Float component binding. |
| dawn::TextureDescriptor descriptor; |
| descriptor.dimension = dawn::TextureDimension::e2D; |
| descriptor.size = {16, 16, 1}; |
| descriptor.arrayLayerCount = 1; |
| descriptor.sampleCount = 1; |
| descriptor.format = dawn::TextureFormat::RGBA8Uint; |
| descriptor.mipLevelCount = 1; |
| descriptor.usage = dawn::TextureUsage::Sampled; |
| dawn::Texture uintTexture = device.CreateTexture(&descriptor); |
| dawn::TextureView uintTextureView = uintTexture.CreateView(); |
| |
| ASSERT_DEVICE_ERROR(utils::MakeBindGroup(device, layout, {{0, uintTextureView}})); |
| } |
| |
| // Check that a texture must have the correct dimension |
| TEST_F(BindGroupValidationTest, TextureDimension) { |
| dawn::BindGroupLayout layout = utils::MakeBindGroupLayout( |
| device, {{0, dawn::ShaderStage::Fragment, dawn::BindingType::SampledTexture, false, false, |
| dawn::TextureViewDimension::e2D, dawn::TextureComponentType::Float}}); |
| |
| // Control case: setting a 2D texture view works. |
| utils::MakeBindGroup(device, layout, {{0, mSampledTextureView}}); |
| |
| // Make a 2DArray texture and try to set it to a 2D binding. |
| dawn::TextureDescriptor descriptor; |
| descriptor.dimension = dawn::TextureDimension::e2D; |
| descriptor.size = {16, 16, 1}; |
| descriptor.arrayLayerCount = 2; |
| descriptor.sampleCount = 1; |
| descriptor.format = dawn::TextureFormat::RGBA8Uint; |
| descriptor.mipLevelCount = 1; |
| descriptor.usage = dawn::TextureUsage::Sampled; |
| dawn::Texture arrayTexture = device.CreateTexture(&descriptor); |
| dawn::TextureView arrayTextureView = arrayTexture.CreateView(); |
| |
| ASSERT_DEVICE_ERROR(utils::MakeBindGroup(device, layout, {{0, arrayTextureView}})); |
| } |
| |
| // Check that a UBO must have the correct usage |
| TEST_F(BindGroupValidationTest, BufferUsageUBO) { |
| dawn::BindGroupLayout layout = utils::MakeBindGroupLayout( |
| device, {{0, dawn::ShaderStage::Fragment, dawn::BindingType::UniformBuffer}}); |
| |
| // Control case: using a buffer with the uniform usage works |
| utils::MakeBindGroup(device, layout, {{0, mUBO, 0, 256}}); |
| |
| // Using a buffer without the uniform usage fails |
| ASSERT_DEVICE_ERROR(utils::MakeBindGroup(device, layout, {{0, mSSBO, 0, 256}})); |
| } |
| |
| // Check that a SSBO must have the correct usage |
| TEST_F(BindGroupValidationTest, BufferUsageSSBO) { |
| dawn::BindGroupLayout layout = utils::MakeBindGroupLayout( |
| device, {{0, dawn::ShaderStage::Fragment, dawn::BindingType::StorageBuffer}}); |
| |
| // Control case: using a buffer with the storage usage works |
| utils::MakeBindGroup(device, layout, {{0, mSSBO, 0, 256}}); |
| |
| // Using a buffer without the storage usage fails |
| ASSERT_DEVICE_ERROR(utils::MakeBindGroup(device, layout, {{0, mUBO, 0, 256}})); |
| } |
| |
| // Tests constraints on the buffer offset for bind groups. |
| TEST_F(BindGroupValidationTest, BufferOffsetAlignment) { |
| dawn::BindGroupLayout layout = utils::MakeBindGroupLayout( |
| device, { |
| {0, dawn::ShaderStage::Vertex, dawn::BindingType::UniformBuffer}, |
| }); |
| |
| // Check that offset 0 is valid |
| utils::MakeBindGroup(device, layout, {{0, mUBO, 0, 512}}); |
| |
| // Check that offset 256 (aligned) is valid |
| utils::MakeBindGroup(device, layout, {{0, mUBO, 256, 256}}); |
| |
| // Check cases where unaligned buffer offset is invalid |
| ASSERT_DEVICE_ERROR(utils::MakeBindGroup(device, layout, {{0, mUBO, 1, 256}})); |
| ASSERT_DEVICE_ERROR(utils::MakeBindGroup(device, layout, {{0, mUBO, 128, 256}})); |
| ASSERT_DEVICE_ERROR(utils::MakeBindGroup(device, layout, {{0, mUBO, 255, 256}})); |
| } |
| |
| // Tests constraints to be sure the buffer binding fits in the buffer |
| TEST_F(BindGroupValidationTest, BufferBindingOOB) { |
| dawn::BindGroupLayout layout = utils::MakeBindGroupLayout( |
| device, { |
| {0, dawn::ShaderStage::Vertex, dawn::BindingType::UniformBuffer}, |
| }); |
| |
| dawn::BufferDescriptor descriptor; |
| descriptor.size = 1024; |
| descriptor.usage = dawn::BufferUsage::Uniform; |
| dawn::Buffer buffer = device.CreateBuffer(&descriptor); |
| |
| // Success case, touching the start of the buffer works |
| utils::MakeBindGroup(device, layout, {{0, buffer, 0, 256}}); |
| |
| // Success case, touching the end of the buffer works |
| utils::MakeBindGroup(device, layout, {{0, buffer, 3*256, 256}}); |
| utils::MakeBindGroup(device, layout, {{0, buffer, 1024, 0}}); |
| |
| // Success case, touching the full buffer works |
| utils::MakeBindGroup(device, layout, {{0, buffer, 0, 1024}}); |
| utils::MakeBindGroup(device, layout, {{0, buffer, 0, dawn::kWholeSize}}); |
| |
| // Error case, offset is OOB |
| ASSERT_DEVICE_ERROR(utils::MakeBindGroup(device, layout, {{0, buffer, 256*5, 0}})); |
| |
| // Error case, size is OOB |
| ASSERT_DEVICE_ERROR(utils::MakeBindGroup(device, layout, {{0, buffer, 0, 256*5}})); |
| |
| // Error case, offset+size is OOB |
| ASSERT_DEVICE_ERROR(utils::MakeBindGroup(device, layout, {{0, buffer, 1024, 1}})); |
| ASSERT_DEVICE_ERROR(utils::MakeBindGroup(device, layout, {{0, buffer, 1, dawn::kWholeSize}})); |
| |
| // Error case, offset+size overflows to be 0 |
| ASSERT_DEVICE_ERROR(utils::MakeBindGroup(device, layout, {{0, buffer, 256, uint32_t(0) - uint32_t(256)}})); |
| } |
| |
| // Test what happens when the layout is an error. |
| TEST_F(BindGroupValidationTest, ErrorLayout) { |
| dawn::BindGroupLayout goodLayout = utils::MakeBindGroupLayout( |
| device, { |
| {0, dawn::ShaderStage::Vertex, dawn::BindingType::UniformBuffer}, |
| }); |
| |
| dawn::BindGroupLayout errorLayout; |
| ASSERT_DEVICE_ERROR( |
| errorLayout = utils::MakeBindGroupLayout( |
| device, { |
| {0, dawn::ShaderStage::Vertex, dawn::BindingType::UniformBuffer}, |
| {0, dawn::ShaderStage::Vertex, dawn::BindingType::UniformBuffer}, |
| })); |
| |
| // Control case, creating with the good layout works |
| utils::MakeBindGroup(device, goodLayout, {{0, mUBO, 0, 256}}); |
| |
| // Control case, creating with the good layout works |
| ASSERT_DEVICE_ERROR(utils::MakeBindGroup(device, errorLayout, {{0, mUBO, 0, 256}})); |
| } |
| |
| class BindGroupLayoutValidationTest : public ValidationTest { |
| public: |
| void TestCreateBindGroupLayout(dawn::BindGroupLayoutBinding* binding, |
| uint32_t count, |
| bool expected) { |
| dawn::BindGroupLayoutDescriptor descriptor; |
| |
| descriptor.bindingCount = count; |
| descriptor.bindings = binding; |
| |
| if (!expected) { |
| ASSERT_DEVICE_ERROR(device.CreateBindGroupLayout(&descriptor)); |
| } else { |
| device.CreateBindGroupLayout(&descriptor); |
| } |
| } |
| |
| void TestCreatePipelineLayout(dawn::BindGroupLayout* bgl, uint32_t count, bool expected) { |
| dawn::PipelineLayoutDescriptor descriptor; |
| |
| descriptor.bindGroupLayoutCount = count; |
| descriptor.bindGroupLayouts = bgl; |
| |
| if (!expected) { |
| ASSERT_DEVICE_ERROR(device.CreatePipelineLayout(&descriptor)); |
| } else { |
| device.CreatePipelineLayout(&descriptor); |
| } |
| } |
| }; |
| |
| // Tests setting OOB checks for kMaxBindingsPerGroup in bind group layouts. |
| TEST_F(BindGroupLayoutValidationTest, BindGroupLayoutBindingOOB) { |
| // Checks that kMaxBindingsPerGroup - 1 is valid. |
| utils::MakeBindGroupLayout(device, {{kMaxBindingsPerGroup - 1, dawn::ShaderStage::Vertex, |
| dawn::BindingType::UniformBuffer}}); |
| |
| // Checks that kMaxBindingsPerGroup is OOB |
| ASSERT_DEVICE_ERROR(utils::MakeBindGroupLayout( |
| device, |
| {{kMaxBindingsPerGroup, dawn::ShaderStage::Vertex, dawn::BindingType::UniformBuffer}})); |
| } |
| |
| // This test verifies that the BindGroupLayout bindings are correctly validated, even if the |
| // binding ids are out-of-order. |
| TEST_F(BindGroupLayoutValidationTest, BindGroupBinding) { |
| utils::MakeBindGroupLayout(device, |
| { |
| {1, dawn::ShaderStage::Vertex, dawn::BindingType::UniformBuffer}, |
| {0, dawn::ShaderStage::Vertex, dawn::BindingType::UniformBuffer}, |
| }); |
| } |
| |
| // Check that dynamic = true is only allowed with buffer bindings. |
| TEST_F(BindGroupLayoutValidationTest, DynamicAndTypeCompatibility) { |
| utils::MakeBindGroupLayout( |
| device, { |
| {0, dawn::ShaderStage::Compute, dawn::BindingType::UniformBuffer, true}, |
| }); |
| |
| utils::MakeBindGroupLayout( |
| device, { |
| {0, dawn::ShaderStage::Compute, dawn::BindingType::StorageBuffer, true}, |
| }); |
| |
| ASSERT_DEVICE_ERROR(utils::MakeBindGroupLayout( |
| device, { |
| {0, dawn::ShaderStage::Compute, dawn::BindingType::SampledTexture, true}, |
| })); |
| |
| ASSERT_DEVICE_ERROR(utils::MakeBindGroupLayout( |
| device, { |
| {0, dawn::ShaderStage::Compute, dawn::BindingType::Sampler, true}, |
| })); |
| } |
| |
| // This test verifies that visibility of bindings in BindGroupLayout can't be none |
| TEST_F(BindGroupLayoutValidationTest, BindGroupLayoutVisibilityNone) { |
| utils::MakeBindGroupLayout(device, |
| { |
| {0, dawn::ShaderStage::Vertex, dawn::BindingType::UniformBuffer}, |
| }); |
| |
| dawn::BindGroupLayoutBinding binding = {0, dawn::ShaderStage::None, |
| dawn::BindingType::UniformBuffer}; |
| dawn::BindGroupLayoutDescriptor descriptor; |
| descriptor.bindingCount = 1; |
| descriptor.bindings = &binding; |
| ASSERT_DEVICE_ERROR(device.CreateBindGroupLayout(&descriptor)); |
| } |
| |
| // Check that dynamic buffer numbers exceed maximum value in one bind group layout. |
| TEST_F(BindGroupLayoutValidationTest, DynamicBufferNumberLimit) { |
| dawn::BindGroupLayout bgl[2]; |
| std::vector<dawn::BindGroupLayoutBinding> maxUniformDB; |
| std::vector<dawn::BindGroupLayoutBinding> maxStorageDB; |
| |
| for (uint32_t i = 0; i < kMaxDynamicUniformBufferCount; ++i) { |
| maxUniformDB.push_back( |
| {i, dawn::ShaderStage::Compute, dawn::BindingType::UniformBuffer, true}); |
| } |
| |
| for (uint32_t i = 0; i < kMaxDynamicStorageBufferCount; ++i) { |
| maxStorageDB.push_back( |
| {i, dawn::ShaderStage::Compute, dawn::BindingType::StorageBuffer, true}); |
| } |
| |
| auto MakeBindGroupLayout = [&](dawn::BindGroupLayoutBinding* binding, |
| uint32_t count) -> dawn::BindGroupLayout { |
| dawn::BindGroupLayoutDescriptor descriptor; |
| descriptor.bindingCount = count; |
| descriptor.bindings = binding; |
| return device.CreateBindGroupLayout(&descriptor); |
| }; |
| |
| { |
| bgl[0] = MakeBindGroupLayout(maxUniformDB.data(), maxUniformDB.size()); |
| bgl[1] = MakeBindGroupLayout(maxStorageDB.data(), maxStorageDB.size()); |
| |
| TestCreatePipelineLayout(bgl, 2, true); |
| } |
| |
| // Check dynamic uniform buffers excedd maximum in pipeline layout. |
| { |
| bgl[0] = MakeBindGroupLayout(maxUniformDB.data(), maxUniformDB.size()); |
| bgl[1] = utils::MakeBindGroupLayout( |
| device, { |
| {0, dawn::ShaderStage::Compute, dawn::BindingType::UniformBuffer, true}, |
| }); |
| |
| TestCreatePipelineLayout(bgl, 2, false); |
| } |
| |
| // Check dynamic storage buffers exceed maximum in pipeline layout |
| { |
| bgl[0] = MakeBindGroupLayout(maxStorageDB.data(), maxStorageDB.size()); |
| bgl[1] = utils::MakeBindGroupLayout( |
| device, { |
| {0, dawn::ShaderStage::Compute, dawn::BindingType::StorageBuffer, true}, |
| }); |
| |
| TestCreatePipelineLayout(bgl, 2, false); |
| } |
| |
| // Check dynamic uniform buffers exceed maximum in bind group layout. |
| { |
| maxUniformDB.push_back({kMaxDynamicUniformBufferCount, dawn::ShaderStage::Compute, |
| dawn::BindingType::UniformBuffer, true}); |
| TestCreateBindGroupLayout(maxUniformDB.data(), maxUniformDB.size(), false); |
| } |
| |
| // Check dynamic storage buffers exceed maximum in bind group layout. |
| { |
| maxStorageDB.push_back({kMaxDynamicStorageBufferCount, dawn::ShaderStage::Compute, |
| dawn::BindingType::StorageBuffer, true}); |
| TestCreateBindGroupLayout(maxStorageDB.data(), maxStorageDB.size(), false); |
| } |
| } |
| |
| constexpr uint64_t kBufferSize = 2 * kMinDynamicBufferOffsetAlignment + 8; |
| constexpr uint32_t kBindingSize = 9; |
| |
| class SetBindGroupValidationTest : public ValidationTest { |
| public: |
| void SetUp() override { |
| mBindGroupLayout = utils::MakeBindGroupLayout( |
| device, {{0, dawn::ShaderStage::Compute | dawn::ShaderStage::Fragment, |
| dawn::BindingType::UniformBuffer, true}, |
| {1, dawn::ShaderStage::Compute | dawn::ShaderStage::Fragment, |
| dawn::BindingType::StorageBuffer, true}}); |
| } |
| |
| dawn::Buffer CreateBuffer(uint64_t bufferSize, dawn::BufferUsage usage) { |
| dawn::BufferDescriptor bufferDescriptor; |
| bufferDescriptor.size = bufferSize; |
| bufferDescriptor.usage = usage; |
| |
| return device.CreateBuffer(&bufferDescriptor); |
| } |
| |
| dawn::BindGroupLayout mBindGroupLayout; |
| dawn::Buffer mUniformBuffer; |
| dawn::Buffer mStorageBuffer; |
| |
| dawn::RenderPipeline CreateRenderPipeline() { |
| dawn::ShaderModule vsModule = |
| utils::CreateShaderModule(device, utils::SingleShaderStage::Vertex, R"( |
| #version 450 |
| void main() { |
| })"); |
| |
| dawn::ShaderModule fsModule = |
| utils::CreateShaderModule(device, utils::SingleShaderStage::Fragment, R"( |
| #version 450 |
| layout(std140, set = 0, binding = 0) uniform uBuffer { |
| vec2 value1; |
| }; |
| layout(std140, set = 0, binding = 1) buffer SBuffer { |
| vec2 value2; |
| } sBuffer; |
| layout(location = 0) out uvec4 fragColor; |
| void main() { |
| })"); |
| |
| utils::ComboRenderPipelineDescriptor pipelineDescriptor(device); |
| pipelineDescriptor.vertexStage.module = vsModule; |
| pipelineDescriptor.cFragmentStage.module = fsModule; |
| dawn::PipelineLayout pipelineLayout = |
| utils::MakeBasicPipelineLayout(device, &mBindGroupLayout); |
| pipelineDescriptor.layout = pipelineLayout; |
| return device.CreateRenderPipeline(&pipelineDescriptor); |
| } |
| |
| dawn::ComputePipeline CreateComputePipeline() { |
| dawn::ShaderModule csModule = |
| utils::CreateShaderModule(device, utils::SingleShaderStage::Compute, R"( |
| #version 450 |
| const uint kTileSize = 4; |
| const uint kInstances = 11; |
| |
| layout(local_size_x = kTileSize, local_size_y = kTileSize, local_size_z = 1) in; |
| layout(std140, set = 0, binding = 0) uniform UniformBuffer { |
| float value1; |
| }; |
| layout(std140, set = 0, binding = 1) buffer SBuffer { |
| float value2; |
| } dst; |
| |
| void main() { |
| })"); |
| |
| dawn::PipelineLayout pipelineLayout = |
| utils::MakeBasicPipelineLayout(device, &mBindGroupLayout); |
| |
| dawn::ComputePipelineDescriptor csDesc; |
| csDesc.layout = pipelineLayout; |
| csDesc.computeStage.module = csModule; |
| csDesc.computeStage.entryPoint = "main"; |
| |
| return device.CreateComputePipeline(&csDesc); |
| } |
| |
| void TestRenderPassBindGroup(dawn::BindGroup bindGroup, |
| uint64_t* offsets, |
| uint32_t count, |
| bool expectation) { |
| dawn::RenderPipeline renderPipeline = CreateRenderPipeline(); |
| DummyRenderPass renderPass(device); |
| |
| dawn::CommandEncoder commandEncoder = device.CreateCommandEncoder(); |
| dawn::RenderPassEncoder renderPassEncoder = commandEncoder.BeginRenderPass(&renderPass); |
| renderPassEncoder.SetPipeline(renderPipeline); |
| renderPassEncoder.SetBindGroup(0, bindGroup, count, offsets); |
| renderPassEncoder.Draw(3, 1, 0, 0); |
| renderPassEncoder.EndPass(); |
| if (!expectation) { |
| ASSERT_DEVICE_ERROR(commandEncoder.Finish()); |
| } else { |
| commandEncoder.Finish(); |
| } |
| } |
| |
| void TestComputePassBindGroup(dawn::BindGroup bindGroup, |
| uint64_t* offsets, |
| uint32_t count, |
| bool expectation) { |
| dawn::ComputePipeline computePipeline = CreateComputePipeline(); |
| |
| dawn::CommandEncoder commandEncoder = device.CreateCommandEncoder(); |
| dawn::ComputePassEncoder computePassEncoder = commandEncoder.BeginComputePass(); |
| computePassEncoder.SetPipeline(computePipeline); |
| computePassEncoder.SetBindGroup(0, bindGroup, count, offsets); |
| computePassEncoder.Dispatch(1, 1, 1); |
| computePassEncoder.EndPass(); |
| if (!expectation) { |
| ASSERT_DEVICE_ERROR(commandEncoder.Finish()); |
| } else { |
| commandEncoder.Finish(); |
| } |
| } |
| }; |
| |
| // This is the test case that should work. |
| TEST_F(SetBindGroupValidationTest, Basic) { |
| // Set up the bind group. |
| dawn::Buffer uniformBuffer = CreateBuffer(kBufferSize, dawn::BufferUsage::Uniform); |
| dawn::Buffer storageBuffer = CreateBuffer(kBufferSize, dawn::BufferUsage::Storage); |
| dawn::BindGroup bindGroup = utils::MakeBindGroup( |
| device, mBindGroupLayout, |
| {{0, uniformBuffer, 0, kBindingSize}, {1, storageBuffer, 0, kBindingSize}}); |
| |
| std::array<uint64_t, 2> offsets = {256, 0}; |
| |
| TestRenderPassBindGroup(bindGroup, offsets.data(), 2, true); |
| |
| TestComputePassBindGroup(bindGroup, offsets.data(), 2, true); |
| } |
| |
| // Test cases that test dynamic offsets count mismatch with bind group layout. |
| TEST_F(SetBindGroupValidationTest, DynamicOffsetsMismatch) { |
| // Set up bind group. |
| dawn::Buffer uniformBuffer = CreateBuffer(kBufferSize, dawn::BufferUsage::Uniform); |
| dawn::Buffer storageBuffer = CreateBuffer(kBufferSize, dawn::BufferUsage::Storage); |
| dawn::BindGroup bindGroup = utils::MakeBindGroup( |
| device, mBindGroupLayout, |
| {{0, uniformBuffer, 0, kBindingSize}, {1, storageBuffer, 0, kBindingSize}}); |
| |
| // Number of offsets mismatch. |
| std::array<uint64_t, 1> mismatchOffsets = {0}; |
| |
| TestRenderPassBindGroup(bindGroup, mismatchOffsets.data(), 1, false); |
| |
| TestComputePassBindGroup(bindGroup, mismatchOffsets.data(), 1, false); |
| } |
| |
| // Test cases that test dynamic offsets not aligned |
| TEST_F(SetBindGroupValidationTest, DynamicOffsetsNotAligned) { |
| // Set up bind group. |
| dawn::Buffer uniformBuffer = CreateBuffer(kBufferSize, dawn::BufferUsage::Uniform); |
| dawn::Buffer storageBuffer = CreateBuffer(kBufferSize, dawn::BufferUsage::Storage); |
| dawn::BindGroup bindGroup = utils::MakeBindGroup( |
| device, mBindGroupLayout, |
| {{0, uniformBuffer, 0, kBindingSize}, {1, storageBuffer, 0, kBindingSize}}); |
| |
| // Dynamic offsets are not aligned. |
| std::array<uint64_t, 2> notAlignedOffsets = {1, 2}; |
| |
| TestRenderPassBindGroup(bindGroup, notAlignedOffsets.data(), 2, false); |
| |
| TestComputePassBindGroup(bindGroup, notAlignedOffsets.data(), 2, false); |
| } |
| |
| // Test cases that test dynamic uniform buffer out of bound situation. |
| TEST_F(SetBindGroupValidationTest, OffsetOutOfBoundDynamicUniformBuffer) { |
| // Set up bind group. |
| dawn::Buffer uniformBuffer = CreateBuffer(kBufferSize, dawn::BufferUsage::Uniform); |
| dawn::Buffer storageBuffer = CreateBuffer(kBufferSize, dawn::BufferUsage::Storage); |
| dawn::BindGroup bindGroup = utils::MakeBindGroup( |
| device, mBindGroupLayout, |
| {{0, uniformBuffer, 0, kBindingSize}, {1, storageBuffer, 0, kBindingSize}}); |
| |
| // Dynamic offset + offset is larger than buffer size. |
| std::array<uint64_t, 2> overFlowOffsets = {1024, 0}; |
| |
| TestRenderPassBindGroup(bindGroup, overFlowOffsets.data(), 2, false); |
| |
| TestComputePassBindGroup(bindGroup, overFlowOffsets.data(), 2, false); |
| } |
| |
| // Test cases that test dynamic storage buffer out of bound situation. |
| TEST_F(SetBindGroupValidationTest, OffsetOutOfBoundDynamicStorageBuffer) { |
| // Set up bind group. |
| dawn::Buffer uniformBuffer = CreateBuffer(kBufferSize, dawn::BufferUsage::Uniform); |
| dawn::Buffer storageBuffer = CreateBuffer(kBufferSize, dawn::BufferUsage::Storage); |
| dawn::BindGroup bindGroup = utils::MakeBindGroup( |
| device, mBindGroupLayout, |
| {{0, uniformBuffer, 0, kBindingSize}, {1, storageBuffer, 0, kBindingSize}}); |
| |
| // Dynamic offset + offset is larger than buffer size. |
| std::array<uint64_t, 2> overFlowOffsets = {0, 1024}; |
| |
| TestRenderPassBindGroup(bindGroup, overFlowOffsets.data(), 2, false); |
| |
| TestComputePassBindGroup(bindGroup, overFlowOffsets.data(), 2, false); |
| } |
| |
| // Test cases that test dynamic uniform buffer out of bound situation because of binding size. |
| TEST_F(SetBindGroupValidationTest, BindingSizeOutOfBoundDynamicUniformBuffer) { |
| // Set up bind group, but binding size is larger than |
| dawn::Buffer uniformBuffer = CreateBuffer(kBufferSize, dawn::BufferUsage::Uniform); |
| dawn::Buffer storageBuffer = CreateBuffer(kBufferSize, dawn::BufferUsage::Storage); |
| dawn::BindGroup bindGroup = utils::MakeBindGroup( |
| device, mBindGroupLayout, |
| {{0, uniformBuffer, 0, kBindingSize}, {1, storageBuffer, 0, kBindingSize}}); |
| |
| // Dynamic offset + offset isn't larger than buffer size. |
| // But with binding size, it will trigger OOB error. |
| std::array<uint64_t, 2> offsets = {512, 0}; |
| |
| TestRenderPassBindGroup(bindGroup, offsets.data(), 2, false); |
| |
| TestComputePassBindGroup(bindGroup, offsets.data(), 2, false); |
| } |
| |
| // Test cases that test dynamic storage buffer out of bound situation because of binding size. |
| TEST_F(SetBindGroupValidationTest, BindingSizeOutOfBoundDynamicStorageBuffer) { |
| dawn::Buffer uniformBuffer = CreateBuffer(kBufferSize, dawn::BufferUsage::Uniform); |
| dawn::Buffer storageBuffer = CreateBuffer(kBufferSize, dawn::BufferUsage::Storage); |
| dawn::BindGroup bindGroup = utils::MakeBindGroup( |
| device, mBindGroupLayout, |
| {{0, uniformBuffer, 0, kBindingSize}, {1, storageBuffer, 0, kBindingSize}}); |
| // Dynamic offset + offset isn't larger than buffer size. |
| // But with binding size, it will trigger OOB error. |
| std::array<uint64_t, 2> offsets = {0, 512}; |
| |
| TestRenderPassBindGroup(bindGroup, offsets.data(), 2, false); |
| |
| TestComputePassBindGroup(bindGroup, offsets.data(), 2, false); |
| } |
| |
| // Test that an error is produced (and no ASSERTs fired) when using an error bindgroup in |
| // SetBindGroup |
| TEST_F(SetBindGroupValidationTest, ErrorBindGroup) { |
| // Bindgroup creation fails because not all bindings are specified. |
| dawn::BindGroup bindGroup; |
| ASSERT_DEVICE_ERROR(bindGroup = utils::MakeBindGroup(device, mBindGroupLayout, {})); |
| |
| TestRenderPassBindGroup(bindGroup, nullptr, 0, false); |
| |
| TestComputePassBindGroup(bindGroup, nullptr, 0, false); |
| } |
