Revert "[dawn][native] Add support filteringness attributes to GetBindGroupLayout"

This reverts commit 601b743258cfddee3abf105c05137662d2b8dfc9.

Reason for revert: Breaking roll into chromium starting at
https://crrev.com/c/7649380
Verified this commit is the culprit in a local build using
https://webgpu.github.io/webgpu-samples/?sample=videoUploading
Logs below:

[21588:266058:0309/152952.068414:ERROR:third_party/blink/renderer/modules/webgpu/gpu_device.cc:371] GPUDevice: "Filtering sampler [Sampler (unlabeled)] is incompatible with non-filtering sampler binding.\n - While validating entries[0] against { binding: 0, visibility: ShaderStage::Fragment, sampler: {type: SamplerBindingType::NonFiltering} }.\n - While validating [BindGroupDescriptor] against [BindGroupLayout (unlabeled)]\n - While calling [Device].CreateBindGroup([BindGroupDescriptor]).\n"

Original change's description:
> [dawn][native] Add support filteringness attributes to GetBindGroupLayout
>
> This lets GetBindGroupLayout return BGLs that reflect the filterability
> / filteringness attributes set in the shaders. A resolve algorithm is
> added for "unknown" sampler filteringness / texture filterability that
> matches the behavior required in WebGPU without support for these
> attributes.
>
> A partial test plan is added as a TODO.
>
> Bug: 487593147
> Change-Id: I3ae6df2a32b7bdcfe973241e6e2d887ed2238619
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/294455
> Reviewed-by: dan sinclair <dsinclair@chromium.org>
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
> Commit-Queue: dan sinclair <dsinclair@chromium.org>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 487593147
Change-Id: I628231c31300aed39e124dc79497d463e6390018
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/296615
Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Reviewed-by: Gregg Tavares <gman@chromium.org>
Auto-Submit: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
2 files changed
tree: ec25469c24556a19d90e8d90509c17e5ca4b7675
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. .bazelrc
  15. .clang-format
  16. .clang-format-ignore
  17. .clang-tidy
  18. .git-blame-ignore-revs
  19. .gitattributes
  20. .gitignore
  21. .gitmodules
  22. .gn
  23. .style.yapf
  24. .vpython3
  25. AUTHORS
  26. BUILD.bazel
  27. BUILD.gn
  28. CMakeLists.txt
  29. CMakeSettings.json
  30. CODE_OF_CONDUCT.md
  31. codereview.settings
  32. CONTRIBUTING.md
  33. CPPLINT.cfg
  34. DEPS
  35. DIR_METADATA
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. test_spec_presubmit_support.py
  45. unsafe_buffers_paths.txt
  46. WATCHLISTS
  47. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.