Revert "[dawn][native] Add support filteringness attributes to GetBindGroupLayout" This reverts commit 601b743258cfddee3abf105c05137662d2b8dfc9. Reason for revert: Breaking roll into chromium starting at https://crrev.com/c/7649380 Verified this commit is the culprit in a local build using https://webgpu.github.io/webgpu-samples/?sample=videoUploading Logs below: [21588:266058:0309/152952.068414:ERROR:third_party/blink/renderer/modules/webgpu/gpu_device.cc:371] GPUDevice: "Filtering sampler [Sampler (unlabeled)] is incompatible with non-filtering sampler binding.\n - While validating entries[0] against { binding: 0, visibility: ShaderStage::Fragment, sampler: {type: SamplerBindingType::NonFiltering} }.\n - While validating [BindGroupDescriptor] against [BindGroupLayout (unlabeled)]\n - While calling [Device].CreateBindGroup([BindGroupDescriptor]).\n" Original change's description: > [dawn][native] Add support filteringness attributes to GetBindGroupLayout > > This lets GetBindGroupLayout return BGLs that reflect the filterability > / filteringness attributes set in the shaders. A resolve algorithm is > added for "unknown" sampler filteringness / texture filterability that > matches the behavior required in WebGPU without support for these > attributes. > > A partial test plan is added as a TODO. > > Bug: 487593147 > Change-Id: I3ae6df2a32b7bdcfe973241e6e2d887ed2238619 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/294455 > Reviewed-by: dan sinclair <dsinclair@chromium.org> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Auto-Submit: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: dan sinclair <dsinclair@chromium.org> # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 487593147 Change-Id: I628231c31300aed39e124dc79497d463e6390018 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/296615 Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: dan sinclair <dsinclair@chromium.org> Reviewed-by: Gregg Tavares <gman@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Commit-Queue: dan sinclair <dsinclair@chromium.org>
Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.
Dawn provides several WebGPU building blocks:
webgpu.h version that Dawn implements.webgpu.h.Helpful links:
Developer documentation:
User documentation: (TODO, figure out what overlaps with the webgpu.h docs)
BSD 3-Clause License, please see LICENSE.
This is not an officially supported Google product.