Google Git
Sign in
dawn / dawn / 4eb384e1341d2999f21a6cfb222f3fd0de0a64b7
commit4eb384e1341d2999f21a6cfb222f3fd0de0a64b7[log] [tgz]
authorKai Ninomiya <kainino@chromium.org>Thu Jul 31 14:26:32 2025 -0700
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jul 31 14:26:32 2025 -0700
tree561964ffe43f4f3f377cfb50466346689c8d6e3f
parent34d315a55b42abec66815c945b5cbda27259fe77 [diff]
[emscripten] Fix memory management of WGPUCompilationInfo

library_webgpu.js would allocate space for WGPUCompilationMessages and
their strings and Utf16 chain structs, even if there were no messages.
Fix library_webgpu.js and webgpu.cpp so they're in sync about when they
need to malloc/free.

- Fixes a UB crash when trying to access messages[0] to free the Utf16
  chain but there isn't actually a messages[0] at all. (This is only
  caught by the test in ASAN builds.)
- Fixes a leak of the string allocation when there is no messages[0] so
  the freeing code can't get the pointer to free. (This is definitely a
  leak because we always allocate at least one byte. The other two
  allocations may also have leaked, but their allocation sizes were 0.)

Tangentially, add -sSAFE_HEAP to debug builds (though this does not
catch the bug, that requires a real ASAN build).

Fixed: 429140232
Change-Id: Iab2f11e4cbceaa568a7c6633e2501dc3bbb1ce87
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/255497
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
4 files changed
tree: 561964ffe43f4f3f377cfb50466346689c8d6e3f
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-format-ignore
  20. .clang-tidy
  21. .git-blame-ignore-revs
  22. .gitattributes
  23. .gitignore
  24. .gitmodules
  25. .gn
  26. .style.yapf
  27. .vpython3
  28. AUTHORS
  29. BUILD.bazel
  30. BUILD.gn
  31. CMakeLists.txt
  32. CMakeSettings.json
  33. CODE_OF_CONDUCT.md
  34. codereview.settings
  35. CONTRIBUTING.md
  36. CPPLINT.cfg
  37. DEPS
  38. DIR_METADATA
  39. go.mod
  40. go.sum
  41. go_presubmit_support.py
  42. LICENSE
  43. OWNERS
  44. PRESUBMIT.py
  45. README.chromium
  46. README.md
  47. WATCHLISTS
  48. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.