commit 51edb2b2d0ede5603432bc6b7f41f6ebc46370a9
author Ben Clayton <bclayton@google.com> Mon Apr 12 17:41:23 2021 +0000
committer Commit Bot service account <commit-bot@chromium.org> Mon Apr 12 17:41:23 2021 +0000
tree a2722e11c37ff6ade426c7172cbde4470b947d55
parent faea7f78414e21abe84cc072409f358d02a47ee6

Reenable D3D12 tests that use workgroup storage

Now fixed.

Fixed: tint:688
Change-Id: Ic1fcd487e5fc242dc150e9db1a163c2af07c6f09
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46449
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>

src/tests/end2end/ComputeSharedMemoryTests.cpp

diff --git a/src/tests/end2end/ComputeSharedMemoryTests.cpp b/src/tests/end2end/ComputeSharedMemoryTests.cpp
index 2d60148..2bc4d61 100644
--- a/src/tests/end2end/ComputeSharedMemoryTests.cpp
+++ b/src/tests/end2end/ComputeSharedMemoryTests.cpp
@@ -22,13 +22,6 @@
   public:
     static constexpr uint32_t kInstances = 11;
 
-    void SetUp() override {
-        DawnTest::SetUp();
-
-        // TODO(crbug.com/tint/688): error: undeclared identifier '_tint_7'
-        DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
-    }
-
     void BasicTest(const char* shader);
 };
 

src/tests/end2end/ObjectCachingTests.cpp

diff --git a/src/tests/end2end/ObjectCachingTests.cpp b/src/tests/end2end/ObjectCachingTests.cpp
index ce8758c..bf233b7 100644
--- a/src/tests/end2end/ObjectCachingTests.cpp
+++ b/src/tests/end2end/ObjectCachingTests.cpp
@@ -17,15 +17,7 @@
 #include "utils/ComboRenderPipelineDescriptor.h"
 #include "utils/WGPUHelpers.h"
 
-class ObjectCachingTest : public DawnTest {
-  protected:
-    void SetUp() override {
-        DawnTest::SetUp();
-
-        // TODO(crbug.com/tint/688): error: undeclared identifier '_tint_7'
-        DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
-    }
-};
+class ObjectCachingTest : public DawnTest {};
 
 // Test that BindGroupLayouts are correctly deduplicated.
 TEST_P(ObjectCachingTest, BindGroupLayoutDeduplication) {