commit 56996023fe9dc3818f07ffe877dfd12f19430ea9
author Ben Clayton <bclayton@google.com> Tue Dec 15 16:33:19 2020 +0000
committer Commit Bot service account <commit-bot@chromium.org> Tue Dec 15 16:33:19 2020 +0000
tree 8413941c19a5ffd11bf8f02f477af9138fb4ae01
parent f46720fe43becc4e0391c60a8217e4cd1cb02802

end2end: Enable DepthReplacing tint tests

These are fixed by:
https://dawn-review.googlesource.com/c/tint/+/35500

Fixed: tint:329
Change-Id: I33105e392c6dfbe75a4d716fe98805dbe696c2ea
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/35721
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@google.com>
Reviewed-by: Corentin Wallez <cwallez@google.com>

src/tests/end2end/DepthStencilCopyTests.cpp

diff --git a/src/tests/end2end/DepthStencilCopyTests.cpp b/src/tests/end2end/DepthStencilCopyTests.cpp
index 3ab4fd1..5591cf1 100644
--- a/src/tests/end2end/DepthStencilCopyTests.cpp
+++ b/src/tests/end2end/DepthStencilCopyTests.cpp
@@ -27,10 +27,6 @@
     void SetUp() override {
         DawnTest::SetUp();
 
-        // TODO(crbug.com/tint/329): SPIR-V output missing DepthReplacing execution mode.
-        DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator") &&
-                          (IsVulkan() || IsOpenGL() || IsOpenGLES()));
-
         // Draw a square in the bottom left quarter of the screen.
         mVertexModule = utils::CreateShaderModuleFromWGSL(device, R"(
             [[builtin(vertex_idx)]] var<in> VertexIndex : u32;

src/tests/end2end/MultisampledRenderingTests.cpp

diff --git a/src/tests/end2end/MultisampledRenderingTests.cpp b/src/tests/end2end/MultisampledRenderingTests.cpp
index 3766320..d7d78af 100644
--- a/src/tests/end2end/MultisampledRenderingTests.cpp
+++ b/src/tests/end2end/MultisampledRenderingTests.cpp
@@ -315,10 +315,6 @@
 
 // Test multisampled rendering with depth test works correctly.
 TEST_P(MultisampledRenderingTest, MultisampledRenderingWithDepthTest) {
-    // TODO(crbug.com/tint/329): SPIR-V output missing DepthReplacing execution mode.
-    DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator") &&
-                      (IsVulkan() || IsOpenGL() || IsOpenGLES()));
-
     constexpr bool kTestDepth = true;
     wgpu::CommandEncoder commandEncoder = device.CreateCommandEncoder();
     wgpu::RenderPipeline pipeline = CreateRenderPipelineWithOneOutputForTest(kTestDepth);
@@ -674,10 +670,6 @@
     // TODO(dawn:491): Find out why this test doesn't work on Windows Intel Vulkan.
     DAWN_SKIP_TEST_IF(IsWindows() && IsIntel() && IsVulkan());
 
-    // TODO(crbug.com/tint/329): SPIR-V output missing DepthReplacing execution mode.
-    DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator") &&
-                      (IsVulkan() || IsOpenGL() || IsOpenGLES()));
-
     constexpr bool kTestDepth = true;
     // The second sample is included in the first render pass and it's covered by the triangle.
     constexpr uint32_t kSampleMaskGreen = kSecondSampleMaskBit;
@@ -940,10 +932,6 @@
     // algorithm.
     DAWN_SKIP_TEST_IF(IsSwiftshader());
 
-    // TODO(crbug.com/tint/329): SPIR-V output missing DepthReplacing execution mode.
-    DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator") &&
-                      (IsVulkan() || IsOpenGL() || IsOpenGLES()));
-
     constexpr bool kTestDepth = true;
     constexpr uint32_t kSampleMask = 0xFFFFFFFF;
 

src/tests/end2end/MultisampledSamplingTests.cpp

diff --git a/src/tests/end2end/MultisampledSamplingTests.cpp b/src/tests/end2end/MultisampledSamplingTests.cpp
index b0081a8..adb9115 100644
--- a/src/tests/end2end/MultisampledSamplingTests.cpp
+++ b/src/tests/end2end/MultisampledSamplingTests.cpp
@@ -50,9 +50,6 @@
     void SetUp() override {
         DawnTest::SetUp();
 
-        // TODO(crbug.com/tint/329): SPIR-V output missing DepthReplacing execution mode.
-        DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator") &&
-                          (IsVulkan() || IsOpenGL() || IsOpenGLES()));
         {
             utils::ComboRenderPipelineDescriptor desc(device);