Result: Fix documentation and a typo
BUG=
Change-Id: I42425a1ee0a4e62a7c1e090878a9d61534eaf784
Reviewed-on: https://dawn-review.googlesource.com/c/2700
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
diff --git a/src/common/Result.h b/src/common/Result.h
index 1aeac54..326144c 100644
--- a/src/common/Result.h
+++ b/src/common/Result.h
@@ -38,11 +38,11 @@
// The interface of Result<T, E> shoud look like the following.
// public:
-// Result(T success);
-// Result(E error);
+// Result(T&& success);
+// Result(E&& error);
//
// Result(Result<T, E>&& other);
-// Result<T, E>&& operator=(Result<T, E>&& other);
+// Result<T, E>& operator=(Result<T, E>&& other);
//
// ~Result();
//
@@ -113,8 +113,8 @@
Empty = 2,
};
- // Utility functions to manipulate the tagged pointer some of them don't need to be templated
- // but we really want them inlined so we keep them in templates
+ // Utility functions to manipulate the tagged pointer. Some of them don't need to be templated
+ // but we really want them inlined so we keep them in the headers
static intptr_t MakePayload(void* pointer, PayloadType type);
static PayloadType GetPayloadType(intptr_t payload);
static T* GetSuccessFromPayload(intptr_t payload);
