Google Git
Sign in
dawn / dawn / b54d490b0c36d6a6cb9b8cf1a1eaaee75bba0804
commitb54d490b0c36d6a6cb9b8cf1a1eaaee75bba0804[log] [tgz]
authorJiawei Shao <jiawei.shao@intel.com>Fri Jan 19 00:42:36 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jan 19 00:42:36 2024 +0000
tree35947c6951e5f8b683f9d5d685f84c3921447cd1
parent9cfc80a7865ae17e71631cfe481a8d067a3dcc85 [diff]
Support larger maxVertexAttributes (30)

This patch adds the support of larger maxVertexAttributes (30) in Dawn.
The main reason to choose 30 as the Tier1 value of maxVertexAttributes
is that on D3D12 D3D12_IA_VERTEX_INPUT_RESOURCE_SLOT_COUNT is 32, while
both SV_VertexID and SV_InstanceID will consume one vertex input slot.
Otherwise when creating such render pipeline DXC will crash and FXC will
generate below error message:
error X4506: vs_5_1 input limit (32) exceeded, shader uses 33 inputs.

This patch also fixes a bug on the assignment of maxVertexAttributes on
the OpenGL backend. According to OpenGL ES SPEC, attribindex must be
less than the value of GL_MAX_VERTEX_ATTRIBS, so GL_MAX_VERTEX_ATTRIBS
should exactly mean maxVertexAttributes in WebGPU.

Fixed: dawn:2223
Test: dawn_end2end_tests
Change-Id: I1916b2d676296e98f74bf6d17684000ccd7a03bc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/170140
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
7 files changed
tree: 35947c6951e5f8b683f9d5d685f84c3921447cd1
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. AUTHORS
  25. BUILD.bazel
  26. BUILD.gn
  27. CMakeLists.txt
  28. CMakeSettings.json
  29. CODE_OF_CONDUCT.md
  30. codereview.settings
  31. CONTRIBUTING.md
  32. CPPLINT.cfg
  33. DEPS
  34. DIR_METADATA
  35. Doxyfile
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.