Google Git
Sign in
dawn / dawn / 61f763cc38efc138308ff1efa411f5b9bf399210
commit61f763cc38efc138308ff1efa411f5b9bf399210[log] [tgz]
authorNatalie Chouinard <chouinard@google.com>Wed Jun 26 15:36:52 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jun 26 15:36:52 2024 +0000
treeabbbf3e14c52fbe55457c045ddc571999753ff1e
parentfa24f1553becdd220f71e7d84d51a78d08a0d3db [diff]
[Tint] Only allow read textures in vertex shader

For builtin functions that accept textures as arguments, only
non-writable texture types should be allowed in vertex shaders. This is
now addressed in the WGSL definitions and the appropriate generated
tests are fixed.

The manually modified files in this change are:
* src/tint/lang/wgsl/wgsl.def
* src/dawn/tests/unittests/validation/StorageTextureValidationTests.cpp
* src/tint/lang/wgsl/intrinsic/table_test.cc
* src/tint/lang/wgsl/resolver/builtin_test.cc

This does result in a slightly confusing error message of:

`error: built-in cannot be used by vertex pipeline stage`

when a built-in function with a writable texture arg is used (even if the built-in function can be used with a read-only texture), however it will be improved once https://dawn-review.googlesource.com/c/dawn/+/190781/ is merged to:

`error: storage texture with read_write access mode cannot be used by vertex pipeline stage`

Bug: 344846829
Change-Id: I47f544fbea715aa8825c3d13502d9e8740074c95
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/195417
Commit-Queue: Natalie Chouinard <chouinard@google.com>
Reviewed-by: James Price <jrprice@google.com>
4721 files changed
tree: abbbf3e14c52fbe55457c045ddc571999753ff1e
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. AUTHORS
  25. BUILD.bazel
  26. BUILD.gn
  27. CMakeLists.txt
  28. CMakeSettings.json
  29. CODE_OF_CONDUCT.md
  30. codereview.settings
  31. CONTRIBUTING.md
  32. CPPLINT.cfg
  33. DEPS
  34. DIR_METADATA
  35. go.mod
  36. go.sum
  37. go_presubmit_support.py
  38. LICENSE
  39. OWNERS
  40. PRESUBMIT.py
  41. README.chromium
  42. README.md
  43. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.