Google Git
Sign in
dawn / dawn / 693c8d6b37c967e0f8e8d10cf50d39c6e691d05f
commit693c8d6b37c967e0f8e8d10cf50d39c6e691d05f[log] [tgz]
authorKyle Charbonneau <kylechar@google.com>Tue Mar 25 11:56:12 2025 -0700
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Mar 25 11:56:12 2025 -0700
tree2049c192b520eb0bd1bed166a0c2f1982d2307f3
parent6d92a5ca44b6f34e02f2edba5ec3d1973a7f98d8 [diff]
Fix BindGroup destruction race

The destruction of slab allocated BindGroup implementations had a data
race. BindGroup::DestroyImpl() would first trigger
SlabAllocator::Deallocate() and then run the destructor. This means the
memory was returned to the SlabAllocator and could be reused to create a
new BindGroup on another thread while the destructor was running.

Fix the race by running SlabAllocator::Deallocate() after the destructor
has finished. This is accomplished by acquiring a callback from the
BindGroup before the destructor runs and invoking the callback
afterwards.

This has only impacted Android+Graphite so far since it's the only
platform where BindGroups are created/destroyed with the same
BindGroupLayout on multiple threads.

Bug: 384611797
Change-Id: I92bb52517384ddbcc742ec53a69cab9cd4078a83
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/232615
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Quyen Le <lehoangquyen@chromium.org>
Commit-Queue: Kyle Charbonneau <kylechar@google.com>
17 files changed
tree: 2049c192b520eb0bd1bed166a0c2f1982d2307f3
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. AUTHORS
  26. BUILD.bazel
  27. BUILD.gn
  28. CMakeLists.txt
  29. CMakeSettings.json
  30. CODE_OF_CONDUCT.md
  31. codereview.settings
  32. CONTRIBUTING.md
  33. CPPLINT.cfg
  34. DEPS
  35. DIR_METADATA
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. WATCHLISTS
  45. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.