Google Git
Sign in
dawn / dawn / 698f64de7d484f16cf2357e3b7a8b806462e3e3f
commit698f64de7d484f16cf2357e3b7a8b806462e3e3f[log] [tgz]
authorKyle Charbonneau <kylechar@google.com>Fri Jul 11 13:39:01 2025 -0700
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jul 11 13:39:01 2025 -0700
tree51fbc042997277e6f92dc62e22d2e9b4913c8776
parentebda341c7b3c3bcc62ef959239a7e280ec6962da [diff]
Fix ApiObjectList::Destroy() race

There is a race if ApiObjectList::Destroy() is going to destroy an
object and another thread drops the last reference to the object at the
same time. The other thread won't run DestroyImpl() but it will call
`delete this` and delete the object resulting in a use-after-free.
Keeping the ApiObjectList lock during DestroyImpl() calls won't work due
to https://crbug.com/42240929.

Have ApiObjectList::Destroy() acquire a reference to all of the
objects. RefCounted::TryAddRef() is added to expose the try to add
reference functionality that WeakRefData was already using.

Bug: 396294899, 429112750
Change-Id: Ib0dcad57bccac87835c2c6d1cab3609cf0e53ee7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/251196
Commit-Queue: Kyle Charbonneau <kylechar@google.com>
Reviewed-by: Brandon Jones <bajones@chromium.org>
5 files changed
tree: 51fbc042997277e6f92dc62e22d2e9b4913c8776
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-format-ignore
  20. .clang-tidy
  21. .git-blame-ignore-revs
  22. .gitattributes
  23. .gitignore
  24. .gitmodules
  25. .gn
  26. .style.yapf
  27. .vpython3
  28. AUTHORS
  29. BUILD.bazel
  30. BUILD.gn
  31. CMakeLists.txt
  32. CMakeSettings.json
  33. CODE_OF_CONDUCT.md
  34. codereview.settings
  35. CONTRIBUTING.md
  36. CPPLINT.cfg
  37. DEPS
  38. DIR_METADATA
  39. go.mod
  40. go.sum
  41. go_presubmit_support.py
  42. LICENSE
  43. OWNERS
  44. PRESUBMIT.py
  45. README.chromium
  46. README.md
  47. WATCHLISTS
  48. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.