| commit | 69c68d01b2420e77283166ffcc7ddb4b0fbc2505 | [log] [tgz] |
|---|---|---|
| author | Rafael Cintron <rafael.cintron@microsoft.com> | Fri Jan 10 17:58:28 2020 +0000 |
| committer | Commit Bot service account <commit-bot@chromium.org> | Fri Jan 10 17:58:28 2020 +0000 |
| tree | 6e0888b30be9a1da3bbc15c1a3cec3f2d1ede398 | |
| parent | 4950095ac9c1023ef5101eb1bb7ef8804c29981e [diff] |
Improve Memory Management of Result class The way in which the Result class is used in Dawn can be fragile with respect to memory management because the caller of AcquireError must know they need to delete the returned pointer or a memory leak will occur. We've had a couple of instances where developers have accidentally left out the delete call and managed to get past code review. This CL changes the Result class so that it assumes the error is allocated on the heap and forces the caller to use unique_ptr when calling AcquireError. Bug:dawn:320 Change-Id: I13ec953b0c37eaafbd6ce93c2f719b4743676acb Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/14960 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Dawn is an open-source and cross-platform implementation of the work-in-progress WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.
Dawn provides several WebGPU building blocks:
webgpu.h version that Dawn implements.webgpu.h.Helpful links:
Developer documentation:
User documentation: (TODO, figure out what overlaps with webgpu.h docs)
(TODO)
Apache 2.0 Public License, please see LICENSE.
This is not an officially supported Google product.