Google Git
Sign in
dawn / dawn / 6bf611d2363adb8e6ca6920eb2628d0bf4b54f3a
commit6bf611d2363adb8e6ca6920eb2628d0bf4b54f3a[log] [tgz]
authorJames Price <jrprice@google.com>Thu Aug 01 01:23:02 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Aug 01 01:23:02 2024 +0000
tree8465d8adb062cc0f309f8fcfdc3bae7aea04d395
parentf228e5c81078b88d18ae173fc401bd59f9771385 [diff]
[tint] Fix undef arg after ArrayLengthFromUniform

When a function calls `arrayLength` with a user function parameter, it
always expects to receive the length via another parameter. If the
originating variable at the callsite is not in the bindpoint map, we
do not retrieve the length from a UBO, which led to `undef` being
passed as the length argument.

In this scenario, the caller should just call the original
`arrayLength` builtin to get the length.

Fixed: 356441926
Change-Id: I458dfd848c8b4633976ab080e6fd940f1e7be992
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/200920
Auto-Submit: James Price <jrprice@google.com>
Commit-Queue: James Price <jrprice@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
2 files changed
tree: 8465d8adb062cc0f309f8fcfdc3bae7aea04d395
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. AUTHORS
  25. BUILD.bazel
  26. BUILD.gn
  27. CMakeLists.txt
  28. CMakeSettings.json
  29. CODE_OF_CONDUCT.md
  30. codereview.settings
  31. CONTRIBUTING.md
  32. CPPLINT.cfg
  33. DEPS
  34. DIR_METADATA
  35. go.mod
  36. go.sum
  37. go_presubmit_support.py
  38. LICENSE
  39. OWNERS
  40. PRESUBMIT.py
  41. README.chromium
  42. README.md
  43. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.