Google Git
Sign in
dawn / dawn / 76e255b08ce6fa1460256a7cadf1cd541ce8e7b1
commit76e255b08ce6fa1460256a7cadf1cd541ce8e7b1[log] [tgz]
authorRyan Harrison <rharrison@chromium.org>Mon Jun 02 15:33:55 2025 -0700
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jun 02 15:33:55 2025 -0700
tree07749d50f5a6e459448f09fec201a2b6e1a40004
parent3aa147292f7008537b5e476bc77f9a33842b6405 [diff]
[tint][ir] Handle `alignment` of 0 instead of DBZ in `RoundUp`

Recently the checks for alignment and size of elements/members were
removed from the binary decoder, because fundamentally it was a check
that is being duplicated in the validator and thought to be unneeded.

The fuzzer found that these were actually slightly load bearing, since
alignment = 0 will lead to a div by zero in `RoundUp`. When this type
of alignment occurs, either it is a malformed shader that should be
rejected by the validator or an opaque type is being used and there is
special handling for it.

This CL adds a guard to `RoundUp` to just return the initial value if
being asked to round with an alignment of 0.

Fixes: 421228420
Change-Id: I3ff7c542fd4256df3a62e22b58d86d7a3694e031
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/244835
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: James Price <jrprice@google.com>
1 file changed
tree: 07749d50f5a6e459448f09fec201a2b6e1a40004
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-format-ignore
  20. .clang-tidy
  21. .git-blame-ignore-revs
  22. .gitattributes
  23. .gitignore
  24. .gitmodules
  25. .gn
  26. .style.yapf
  27. .vpython3
  28. AUTHORS
  29. BUILD.bazel
  30. BUILD.gn
  31. CMakeLists.txt
  32. CMakeSettings.json
  33. CODE_OF_CONDUCT.md
  34. codereview.settings
  35. CONTRIBUTING.md
  36. CPPLINT.cfg
  37. DEPS
  38. DIR_METADATA
  39. go.mod
  40. go.sum
  41. go_presubmit_support.py
  42. LICENSE
  43. OWNERS
  44. PRESUBMIT.py
  45. README.chromium
  46. README.md
  47. WATCHLISTS
  48. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.