Check the draw type when grouping indirect batches

Presently, the first stage in the indirect draw validation
procedure attempts to optimize the number of passes by grouping
together batches that share the same input indirect buffer.

However, each pass only operates on a single draw type input.
If an indirect buffer is used for both Indexed and NonIndexed
draws, then it is possible to have batches included in a pass
with a mismatching draw type.

Change-Id: If61ce91b0b6a27511e4420051f14cdd3e633dddd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/148440
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2 files changed
tree: ac1acf4ebaf68da71045492d5477bd8d8cf23255
  1. .vscode/
  2. build_overrides/
  3. docs/
  4. generator/
  5. include/
  6. infra/
  7. scripts/
  8. src/
  9. test/
  10. third_party/
  11. tools/
  12. webgpu-cts/
  13. .clang-format
  14. .clang-tidy
  15. .gitattributes
  16. .gitignore
  17. .gitmodules
  18. .gn
  19. AUTHORS
  20. BUILD.gn
  21. CMakeLists.txt
  22. CMakeSettings.json
  23. CODE_OF_CONDUCT.md
  24. codereview.settings
  25. CONTRIBUTING.md
  26. CPPLINT.cfg
  27. dawn.json
  28. dawn_wire.json
  29. DEPS
  30. DIR_METADATA
  31. Doxyfile
  32. go.mod
  33. go.sum
  34. go_presubmit_support.py
  35. LICENSE
  36. OWNERS
  37. PRESUBMIT.py
  38. README.chromium
  39. README.md
README.md

Dawn's logo: a sun rising behind a stylized mountain inspired by the WebGPU logo. The text Dawn is written below it.

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the work-in-progress WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

Status

(TODO)

License

Apache 2.0 Public License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.