Google Git
Sign in
dawn / dawn / 0666b24ec8c7972401f744791d6deebce0db9559
commit0666b24ec8c7972401f744791d6deebce0db9559[log] [tgz]
authorCorentin Wallez <cwallez@chromium.org>Wed Nov 13 15:59:25 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Nov 13 15:59:25 2024 +0000
tree6c98403be9040b67458dcfba59ebbe57cb718ef2
parent25aab4d67ae2a26a2e2ab3f7e4b4dc95ceef5615 [diff]
[dawn] Make EncodingContext::TryEncode fail early on previous errors

All encoder calls go through TryEncode that first checks the status of
the command encoder before calling the code to actually validate/encode
commands. TryEncode did not early-out when an error previously happened.

This appeared to work because any error would cause the encoder.Finish()
to return an error object, so we would just be encoding useless
commands, which is harmless.

However RenderPass.End() performs some validation steps and closing the render
pass involves multiple steps. If validation failures happened in the middle of
them, it would be possible to stay in a partially open state, causing
issues where CommandBufferStateTracker is used while partially working.

This CL adds a new Status to EncodingContext for ErrorInRecording, such
that all future calls to TryEncode early-out. There is some slight
complexity because we need to promote ErrorInRecording to Finished to
preserve the WebGPU semantics of doing device-errors when encoders are
finished.

A regression test is added, and two tests updated that fail because they
expected errors on invalid encoders to become device errors, which is no
longer the case, and more in line with the WebGPU spec.

Bug: 377530684
Change-Id: I3a31c6de636ba7cdc63d54a074671bb19a55c9fb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/214195
Reviewed-by: Loko Kung <lokokung@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
7 files changed
tree: 6c98403be9040b67458dcfba59ebbe57cb718ef2
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. AUTHORS
  26. BUILD.bazel
  27. BUILD.gn
  28. CMakeLists.txt
  29. CMakeSettings.json
  30. CODE_OF_CONDUCT.md
  31. codereview.settings
  32. CONTRIBUTING.md
  33. CPPLINT.cfg
  34. DEPS
  35. DIR_METADATA
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. WATCHLISTS
  45. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.