Google Git
Sign in
dawn / dawn / 7dd8d3e2af2804a4f9a7d09142a324854532f7f5
commit7dd8d3e2af2804a4f9a7d09142a324854532f7f5[log] [tgz]
authorJames Price <jrprice@google.com>Fri Jan 12 18:10:48 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jan 12 18:10:48 2024 +0000
tree89db434405752ddbaf2eed2e9aed2db605bbe0e7
parentf545410e64c67a57bbeb48fa0e29116c60c0a21f [diff]
[tint][uniformity] Fix nested LValue expressions

When an LValue is a dereferenced pointer, we were cutting the analysis
short instead of descending into nested expressions that may contain
uniformity violations or affect the uniformity of the parent.

This CL adds an `is_dereferencing` parameter to
`ProcessLValueExpression()` to track whether we are currently
dereferencing, and moves the logic for partial pointers to the
handling of the root identifier expression. This unifies the logic in
the three different expressions that can cause derefences (unary *,
index accessors, and member accessors).

Bug: tint:2113, tint:2053
Fixed: tint:2139
Change-Id: Ia55b5345590c41ea1b162112ac2545c69a95ba75
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/169265
Commit-Queue: James Price <jrprice@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2 files changed
tree: 89db434405752ddbaf2eed2e9aed2db605bbe0e7
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. AUTHORS
  25. BUILD.bazel
  26. BUILD.gn
  27. CMakeLists.txt
  28. CMakeSettings.json
  29. CODE_OF_CONDUCT.md
  30. codereview.settings
  31. CONTRIBUTING.md
  32. CPPLINT.cfg
  33. DEPS
  34. DIR_METADATA
  35. Doxyfile
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.