commit | 3e122818a2469a62ee72d04fc97796bdebbe6d29 | [log] [tgz] |
---|---|---|
author | Ben Clayton <bclayton@google.com> | Thu Sep 30 07:12:33 2021 +0000 |
committer | Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Sep 30 07:12:33 2021 +0000 |
tree | 48661badcb581f0068c86f55bb36b3cd569cf457 | |
parent | 4d2bc396ea3b0ca6e377c674e3728f80b99e9fc5 [diff] |
dawn_node: Fix stack overflow with Write() In review, the variadic overload of Write() was changed, which adjusted the overload resolution priorities W.R.T the single argument overload: https://dawn-review.googlesource.com/c/dawn/+/64747/3..7/src/dawn_node/utils/Debug.h#b96 This caused the variadic overload to be picked for the single-argument case, leading to stack overflows when calling Write(). Fixed by using perfect forwarding for the single argument case of Write(). Bug: dawn:1123 Change-Id: I21ab290e9c2e4b92ab472552f809484fb7426a45 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/65244 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
Dawn is an open-source and cross-platform implementation of the work-in-progress WebGPU standard. More precisely it implements webgpu.h
that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.
Dawn provides several WebGPU building blocks:
webgpu.h
version that Dawn implements.webgpu.h
.Helpful links:
Developer documentation:
User documentation: (TODO, figure out what overlaps with the webgpu.h docs)
(TODO)
Apache 2.0 Public License, please see LICENSE.
This is not an officially supported Google product.