Google Git
Sign in
dawn / dawn / 7f728fcec16b18c8e5cd215c4e5bb76f2e6d9a35
commit7f728fcec16b18c8e5cd215c4e5bb76f2e6d9a35[log] [tgz]
authorBrandon Jones <bajones@chromium.org>Tue Aug 08 00:11:27 2023 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Aug 08 00:11:27 2023 +0000
treebf9f28cb31f5e52791ca4a7d54f05b96e9a3ccfb
parent47e3312658e36fde6dc8b931cf2ce104c3b46e97 [diff]
Split Vulkan command buffers on compute pass

This is a further generalization of the workaround added for
dawn:1564. It splits the command buffer on Qualcomm GPUs any time
a compute pass follows a render pass in a single command buffer.
This feels like a farily heavy-handed workaround, but where
previously it seemed like the crash only happened if the compute
pass used attachements from the render pass, I'm now seeing some
scenarios where the compute pass shares no resources with the
render pass and still fails unless the command buffer is split.

Fortunately the broadening of scope allows the code to be simpler
and removes the need to track and check render pass attachements.

Bug: dawn:1897
Change-Id: I2c511a22e745ee5804d46337cb52483c009a200e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/144780
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
7 files changed
tree: bf9f28cb31f5e52791ca4a7d54f05b96e9a3ccfb
  1. .vscode/
  2. build_overrides/
  3. docs/
  4. generator/
  5. include/
  6. infra/
  7. scripts/
  8. src/
  9. test/
  10. third_party/
  11. tools/
  12. webgpu-cts/
  13. build
  14. buildtools
  15. testing
  16. .clang-format
  17. .clang-tidy
  18. .gitattributes
  19. .gitignore
  20. .gitmodules
  21. .gn
  22. AUTHORS
  23. BUILD.gn
  24. CMakeLists.txt
  25. CMakeSettings.json
  26. CODE_OF_CONDUCT.md
  27. codereview.settings
  28. CONTRIBUTING.md
  29. CPPLINT.cfg
  30. dawn.json
  31. dawn_wire.json
  32. DEPS
  33. DIR_METADATA
  34. Doxyfile
  35. go.mod
  36. go.sum
  37. go_presubmit_support.py
  38. LICENSE
  39. OWNERS
  40. PRESUBMIT.py
  41. README.chromium
  42. README.md
  43. tint_overrides_with_defaults.gni
README.md

Dawn's logo: a sun rising behind a stylized mountain inspired by the WebGPU logo. The text Dawn is written below it.

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the work-in-progress WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

Status

(TODO)

License

Apache 2.0 Public License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.