Google Git
Sign in
dawn / dawn / 8232b503e3a2184f7ee60be6d4696ae7b6336138
commit8232b503e3a2184f7ee60be6d4696ae7b6336138[log] [tgz]
authorBen Clayton <bclayton@google.com>Thu Jun 29 16:10:29 2023 +0000
committerBen Clayton <bclayton@google.com>Thu Jun 29 16:10:29 2023 +0000
tree27e743a605649b0179ea6a2b74705917eb98107a
parent49af09d96379ff2f8a7eae988e6e3e260c50648f [diff]
[tint][ir] static_assert on non-deterministic instruction ordering

It's all too easy to write code like:

   b.Add(b.Call(ty.i32(), fn_a), b.Call(ty.i32(), fn_b))

As C++ does not define the order in which arguments are evaluated, the
ordering of IR instructions for this type of code is non-deterministic.

This can impact production-code behaviour, so attempt to detect this
pattern and statically assert if multiple, non-reference
ir::Instruction* arguments are passed to a builder function.
Non-reference pointers arguments are typically only obtained by
making function calls, which are most commonly from inner builder
calls.

Change-Id: I0b36526ab0cc5d8077a1a5cc21c55569bdbbe225
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/139521
Reviewed-by: James Price <jrprice@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
1 file changed
tree: 27e743a605649b0179ea6a2b74705917eb98107a
  1. .vscode/
  2. build_overrides/
  3. docs/
  4. generator/
  5. include/
  6. infra/
  7. scripts/
  8. src/
  9. test/
  10. third_party/
  11. tools/
  12. webgpu-cts/
  13. .clang-format
  14. .clang-tidy
  15. .gitattributes
  16. .gitignore
  17. .gn
  18. AUTHORS
  19. BUILD.gn
  20. CMakeLists.txt
  21. CMakeSettings.json
  22. CODE_OF_CONDUCT.md
  23. codereview.settings
  24. CONTRIBUTING.md
  25. CPPLINT.cfg
  26. dawn.json
  27. dawn_wire.json
  28. DEPS
  29. DIR_METADATA
  30. Doxyfile
  31. go.mod
  32. go.sum
  33. go_presubmit_support.py
  34. LICENSE
  35. OWNERS
  36. PRESUBMIT.py
  37. README.chromium
  38. README.md
  39. tint_overrides_with_defaults.gni
README.md

Dawn's logo: a sun rising behind a stylized mountain inspired by the WebGPU logo. The text Dawn is written below it.

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the work-in-progress WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

Status

(TODO)

License

Apache 2.0 Public License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.