Google Git
Sign in
dawn / dawn / 8582bafffa54d01fba95edb662e187a00bcc734f
commit8582bafffa54d01fba95edb662e187a00bcc734f[log] [tgz]
authorStephen White <senorblanco@chromium.org>Wed Oct 30 23:04:30 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Oct 30 23:04:30 2024 +0000
treed1017202a0fe94c096bb9df64db8f663f8e92a67
parent5d9a2b621a31c043dc0b16b8b46ec931bfc66d9e [diff]
OpenGL: fix placeholder sampler in vertex stage.

The pipeline queries each shader stage in turn to ask if it needs
a placeholder sampler (e.g., for textureLoad() with no sampler).
However, CompileShader() was initializing "needsPlaceholderSampler" to
false on each call. If the vertex stage needs a placeholder sampler,
but the fragment stage doesn't, it will be overwritten back to false.

The fix is not to initialize it to false in CompileShader(). It's
already initialized to false by PipelineGL::InitializeBase().

(Long-winded explanation for a one-line fix.)

Bug: 374890770
Change-Id: I98109e2006c12149be1b6eedaaf05fed7c1c5541
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/213054
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2 files changed
tree: d1017202a0fe94c096bb9df64db8f663f8e92a67
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. AUTHORS
  26. BUILD.bazel
  27. BUILD.gn
  28. CMakeLists.txt
  29. CMakeSettings.json
  30. CODE_OF_CONDUCT.md
  31. codereview.settings
  32. CONTRIBUTING.md
  33. CPPLINT.cfg
  34. DEPS
  35. DIR_METADATA
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. WATCHLISTS
  45. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.