commit | 87f51237b46afacaf15db801ae1ec99b33f64ecb | [log] [tgz] |
---|---|---|
author | Quyen Le <lehoangquyen@chromium.org> | Fri Apr 21 03:10:12 2023 +0000 |
committer | Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Apr 21 03:10:12 2023 +0000 |
tree | 13ba8d3d14292d0d77d23b148e488fe249bf9753 | |
parent | cf54bb8c2aa971b67329b0d90923c23e0f8d6baa [diff] |
Revert "Disable frontend cache when implicit device sync is on." This reverts commit 8cc6205bf7cfba2816052a0cc5d81debd8d52028. Reason for revert: Graphite actually reuses the bind groups between draw calls using different pipelines and this change prevents it from happening. Original change's description: > Disable frontend cache when implicit device sync is on. > > Normal behavior of ApiObjectBase's APIRelease() which only locks the > device when last ref dropped is not thread safe if the object is cached > as raw pointers by the device. Example of cached objects: bind group > layout, pipeline, sampler, shader module. > > The following scenario could happen: > - thread A: > - shaderModuleA.APIRealease() > - shaderModuleA.refCount.Decrement() == true (ref count has reached zero) > - going to call shaderModuleA.LockAndDeleteThis(). > - thread B: > - device.CreateShaderModule(). > - lock() > - device.GetOrCreateShaderModule() > - shaderModuleA is in the cache, so return it. > - unlock() > - thread A: > - starting to call shaderModuleA.LockAndDeleteThis() > - lock() > - erase shaderModuleA from the cache. > - delete shaderModuleA. > - unlock() > > This CL disables caching when ImplicitDeviceSynchronization is turned on > until we find a better solution. > > Bug: dawn:1769 > Change-Id: Ideb2a717ece0a40e18bd1c2bef00817262bd25da > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127900 > Commit-Queue: Quyen Le <lehoangquyen@chromium.org> > Reviewed-by: Austin Eng <enga@chromium.org> > Kokoro: Kokoro <noreply+kokoro@google.com> TBR=cwallez@chromium.org,enga@chromium.org,noreply+kokoro@google.com,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com,lehoangquyen@chromium.org Change-Id: Ib13bba8005402d06963865fae919388a91e718f0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:1769 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/128440 Reviewed-by: Austin Eng <enga@chromium.org> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Dawn is an open-source and cross-platform implementation of the work-in-progress WebGPU standard. More precisely it implements webgpu.h
that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.
Dawn provides several WebGPU building blocks:
webgpu.h
version that Dawn implements.webgpu.h
.Helpful links:
Developer documentation:
User documentation: (TODO, figure out what overlaps with the webgpu.h docs)
(TODO)
Apache 2.0 Public License, please see LICENSE.
This is not an officially supported Google product.