commit 8954189545af1423f7885afc7b9bee5778c49253
author Ben Clayton <bclayton@google.com> Thu Dec 01 15:34:55 2022 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Dec 01 15:34:55 2022 +0000
tree 8167b61a1a0d994a2c37fc17be50fda4cd9a6176
parent 527e38b68bb2615a4277a6efae9271ba7291d8ea

tint_common_fuzzer: Don't attempt to use an invalid program

validate_program was not returning 0 for invalid programs that did not contain diagnostics with a severity greater than error.
This lead to broken behavior in logic that used the program.

Bug: chromium:1392853
Change-Id: Id860e266cfe24ade955edf4f2f2a9c26c2e117fa
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112560
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@chromium.org>

src/tint/fuzzers/tint_common_fuzzer.cc

diff --git a/src/tint/fuzzers/tint_common_fuzzer.cc b/src/tint/fuzzers/tint_common_fuzzer.cc
index 1c24f35..15ab7d8 100644
--- a/src/tint/fuzzers/tint_common_fuzzer.cc
+++ b/src/tint/fuzzers/tint_common_fuzzer.cc
@@ -209,11 +209,11 @@
                                    "transformed into an invalid output program");
                 }
             }
+            return 0;
         }
 
         program = std::move(out.program);
         RunInspector(&program);
-
         return 1;
     };