Google Git
Sign in
dawn / dawn / 10ec4ee7efb3c0fd10bdb7191da77cdd6d063ea9
commit10ec4ee7efb3c0fd10bdb7191da77cdd6d063ea9[log] [tgz]
authorAustin Eng <enga@chromium.org>Thu Mar 31 01:26:49 2022 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Mar 31 01:26:49 2022 +0000
tree64357143f0e4412c28457c3327ddb4bcb2cd554f
parent600c97af810d04ffbd4b27b221948bec2a728052 [diff]
Disallow creating a 2D-array view on a multisampled texture

Spec issue: https://github.com/gpuweb/gpuweb/issues/2715
Spec PR: https://github.com/gpuweb/gpuweb/pull/2716

This is invalid in the Metal API because MTLTextureType2DArray is
imcompatible with MTLTextureType2DMultisample, even if the layer
count is 1.

MTLTextureType2DMultisampleArray is not supported until macOS 10.14
and iOS 14.0.

Further, the view type must match between the API and the shader.
a 2D view array requires texture2d_array in MSL.
It would be inconsistent to allow 1-layer 2D arrays which internally
get translated as (non-array) MTLTextureType2DMultisample. You would
expect to need to use texture2d_ms_array in the shader.

Change-Id: Ib9268c1276d3d31e90d6c61118e27fa2afd0617d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85200
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
3 files changed
tree: 64357143f0e4412c28457c3327ddb4bcb2cd554f
  1. .vscode/
  2. build_overrides/
  3. docs/
  4. generator/
  5. include/
  6. infra/
  7. samples/
  8. scripts/
  9. src/
  10. third_party/
  11. tools/
  12. webgpu-cts/
  13. .clang-format
  14. .gitattributes
  15. .gitignore
  16. .gn
  17. AUTHORS
  18. BUILD.gn
  19. CMakeLists.txt
  20. codereview.settings
  21. dawn.json
  22. dawn_wire.json
  23. DEPS
  24. DIR_METADATA
  25. LICENSE
  26. OWNERS
  27. PRESUBMIT.py
  28. README.chromium
  29. README.md
README.md

Dawn's logo: a sun rising behind a stylized mountain inspired by the WebGPU logo. The text Dawn is written below it.

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the work-in-progress WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs:
    • D3D12 on Windows 10
    • Metal on macOS and iOS
    • Vulkan on Windows, Linux, ChromeOS, Android and Fuchsia
    • OpenGL as best effort where available
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

Status

(TODO)

License

Apache 2.0 Public License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.