Google Git
Sign in
dawn / dawn / 8e414a140b4190adf5211dec2f93048f9335f8e0
commit8e414a140b4190adf5211dec2f93048f9335f8e0[log] [tgz]
authorShaobo <shaobo.yan@intel.com>Tue Mar 29 08:14:53 2022 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Mar 29 08:14:53 2022 +0000
treec3516c19eb85e172dd8e8e1a681c701461a609ae
parente055ae5b5278d0b22f55f2014f963feb83b364a7 [diff]
Release D3D11on12Resource Cache after Texture::Destroy() has been called

On D3D12 backend, external texture holds mD3D11on12Resource which caches
D3D11on12Resources and guarding by refptr. The texture will released this ref
until destructor works.

This model leaks the gpu memory if client fails to release all the ref to
the texture.

Instead, external texture also provides a method called "Destroy". It is
called more eagerly and means the external texture is in the end of lifecycle.

So thid CL moves the ref reset of D3D11on12Resource into Destroy(). This prevents
unexpected gpu memory leak caused by client missing ref release call.

Bug: 1308405
Change-Id: I253e1eda192256e4bd1c470e26dcc6af3c234447
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85000
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Shaobo Yan <shaobo.yan@intel.com>
1 file changed
tree: c3516c19eb85e172dd8e8e1a681c701461a609ae
  1. .vscode/
  2. build_overrides/
  3. docs/
  4. generator/
  5. include/
  6. infra/
  7. samples/
  8. scripts/
  9. src/
  10. third_party/
  11. tools/
  12. webgpu-cts/
  13. .clang-format
  14. .gitattributes
  15. .gitignore
  16. .gn
  17. AUTHORS
  18. BUILD.gn
  19. CMakeLists.txt
  20. codereview.settings
  21. dawn.json
  22. dawn_wire.json
  23. DEPS
  24. DIR_METADATA
  25. LICENSE
  26. OWNERS
  27. PRESUBMIT.py
  28. README.chromium
  29. README.md
README.md

Dawn's logo: a sun rising behind a stylized mountain inspired by the WebGPU logo. The text Dawn is written below it.

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the work-in-progress WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs:
    • D3D12 on Windows 10
    • Metal on macOS and iOS
    • Vulkan on Windows, Linux, ChromeOS, Android and Fuchsia
    • OpenGL as best effort where available
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

Status

(TODO)

License

Apache 2.0 Public License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.