commit 95034f6528d4c8ff4c5048d523165b8ceca064bd
author Ben Clayton <bclayton@google.com> Fri Mar 05 01:51:28 2021 +0000
committer Commit Bot service account <commit-bot@chromium.org> Fri Mar 05 01:51:28 2021 +0000
tree af4df0b959091ea85f5510cb7f082fb187707cea
parent 224e4df9535232655c9e5e18a42977432a57c7de

Enable the BoundArrayAccessors tint transform

Change-Id: I44cbfbeb09dadcf22ae77a85cef0aff3bc79b16b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/42860
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>

src/dawn_native/ShaderModule.cpp

diff --git a/src/dawn_native/ShaderModule.cpp b/src/dawn_native/ShaderModule.cpp
index 1ae9379..96b97d9 100644
--- a/src/dawn_native/ShaderModule.cpp
+++ b/src/dawn_native/ShaderModule.cpp
@@ -1102,9 +1102,7 @@
         transformManager.append(std::make_unique<tint::transform::EmitVertexPointSize>());
         transformManager.append(std::make_unique<tint::transform::Spirv>());
         if (GetDevice()->IsRobustnessEnabled()) {
-            // TODO(enga): Run the Tint BoundArrayAccessors transform instead of the SPIRV Tools
-            // one, but it appears to crash after running VertexPulling.
-            // transformManager.append(std::make_unique<tint::transform::BoundArrayAccessors>());
+            transformManager.append(std::make_unique<tint::transform::BoundArrayAccessors>());
         }
 
         tint::Program program;
@@ -1117,9 +1115,6 @@
         }
 
         std::vector<uint32_t> spirv = generator.result();
-        if (GetDevice()->IsRobustnessEnabled()) {
-            DAWN_TRY_ASSIGN(spirv, RunRobustBufferAccessPass(spirv));
-        }
         DAWN_TRY(ValidateSpirv(spirv.data(), spirv.size()));
         return std::move(spirv);
     }