commit 9c061c3437d0be2d94ce4430497edf36dfb8b74c
author Brandon Jones <brandon1.jones@intel.com> Wed Feb 27 09:25:26 2019 +0000
committer Commit Bot service account <commit-bot@chromium.org> Wed Feb 27 09:25:26 2019 +0000
tree 34fb775ec6c33b854afde1bd45f0a55c58e00cf6
parent b2c5023c9c1fa3a15cc1f0f1c43e29b7115cee0e

Add ValidateCanRecordCommands to Debug Marker APIs

Add ValidateCanRecordCommands to debug marker calls in ProgrammablePassEncoder.
Fixes issue found by ClusterFuzz.

Bug=chromium:935902
Bug=dawn:44

Change-Id: If1a4890a9de49a1872711a7b1a875ddc13130e88
Reviewed-on: https://dawn-review.googlesource.com/c/5080
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

src/dawn_native/ProgrammablePassEncoder.cpp

diff --git a/src/dawn_native/ProgrammablePassEncoder.cpp b/src/dawn_native/ProgrammablePassEncoder.cpp
index 7a16f31..143144b 100644
--- a/src/dawn_native/ProgrammablePassEncoder.cpp
+++ b/src/dawn_native/ProgrammablePassEncoder.cpp
@@ -39,6 +39,10 @@
     }
 
     void ProgrammablePassEncoder::InsertDebugMarker(const char* groupLabel) {
+        if (mTopLevelEncoder->ConsumedError(ValidateCanRecordCommands())) {
+            return;
+        }
+
         InsertDebugMarkerCmd* cmd =
             mAllocator->Allocate<InsertDebugMarkerCmd>(Command::InsertDebugMarker);
         new (cmd) InsertDebugMarkerCmd;
@@ -49,11 +53,19 @@
     }
 
     void ProgrammablePassEncoder::PopDebugGroup() {
+        if (mTopLevelEncoder->ConsumedError(ValidateCanRecordCommands())) {
+            return;
+        }
+
         PopDebugGroupCmd* cmd = mAllocator->Allocate<PopDebugGroupCmd>(Command::PopDebugGroup);
         new (cmd) PopDebugGroupCmd;
     }
 
     void ProgrammablePassEncoder::PushDebugGroup(const char* groupLabel) {
+        if (mTopLevelEncoder->ConsumedError(ValidateCanRecordCommands())) {
+            return;
+        }
+
         PushDebugGroupCmd* cmd = mAllocator->Allocate<PushDebugGroupCmd>(Command::PushDebugGroup);
         new (cmd) PushDebugGroupCmd;
         cmd->length = strlen(groupLabel);