commit 9c81f8738a47caff631669dba307cc4b2042a7fb
author Bryan Bernhart <bryan.bernhart@intel.com> Mon Nov 18 23:09:38 2019 +0000
committer Commit Bot service account <commit-bot@chromium.org> Mon Nov 18 23:09:38 2019 +0000
tree d353d0b52e7c06a673841e299c8de50a72415ad4
parent d0c07f112eb2038891b62d529d1d841e06673b67

Allow SetBindGroup command to be skipped with dynamic offsets.

Fixes a bug where SetBindGroup command would fail to be skipped.

BUG=dawn:256

Change-Id: I9815c9d31aa88f6881274a1873cabe17379cc2e0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/13800
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com>

src/dawn_native/Commands.cpp

diff --git a/src/dawn_native/Commands.cpp b/src/dawn_native/Commands.cpp
index b2019a9..3810089 100644
--- a/src/dawn_native/Commands.cpp
+++ b/src/dawn_native/Commands.cpp
@@ -254,9 +254,12 @@
                 commands->NextCommand<SetBlendColorCmd>();
                 break;
 
-            case Command::SetBindGroup:
-                commands->NextCommand<SetBindGroupCmd>();
-                break;
+            case Command::SetBindGroup: {
+                SetBindGroupCmd* cmd = commands->NextCommand<SetBindGroupCmd>();
+                if (cmd->dynamicOffsetCount > 0) {
+                    commands->NextData<uint32_t>(cmd->dynamicOffsetCount);
+                }
+            } break;
 
             case Command::SetIndexBuffer:
                 commands->NextCommand<SetIndexBufferCmd>();