commit 9dbb81f004b65faacbff0e5508bc7b7a40654f2b
author Corentin Wallez <cwallez@chromium.org> Wed Jul 17 14:49:37 2019 +0000
committer Commit Bot service account <commit-bot@chromium.org> Wed Jul 17 14:49:37 2019 +0000
tree 0f8fdc095c8649151897ba4be2d5031e3e5c24b1
parent ee0fa175a347df4ae1ea8ff8b7f202c8c2ebc0ca

Add missing validation for unsupported texture view dims.

BUG=chromium:984809

Change-Id: Iea6bf88f79f9749237052c16e0ab2dd15d7d4308
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9081
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

src/dawn_native/Texture.cpp

diff --git a/src/dawn_native/Texture.cpp b/src/dawn_native/Texture.cpp
index 8a83a89..d3c034e 100644
--- a/src/dawn_native/Texture.cpp
+++ b/src/dawn_native/Texture.cpp
@@ -373,6 +373,11 @@
         }
 
         DAWN_TRY(ValidateTextureViewDimension(descriptor->dimension));
+        if (descriptor->dimension == dawn::TextureViewDimension::e1D ||
+            descriptor->dimension == dawn::TextureViewDimension::e3D) {
+            return DAWN_VALIDATION_ERROR("Texture view dimension must be 2D compatible.");
+        }
+
         DAWN_TRY(ValidateTextureFormat(descriptor->format));
 
         // TODO(jiawei.shao@intel.com): check stuff based on resource limits