Google Git
Sign in
dawn / dawn / 9dc42add8fdeb00c36aaaa3ed2d19d4bdfbc6ab6
commit9dc42add8fdeb00c36aaaa3ed2d19d4bdfbc6ab6[log] [tgz]
authorBen Clayton <bclayton@google.com>Mon Feb 05 18:01:33 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Feb 05 18:01:33 2024 +0000
tree2715a4f5686ead39b8e9e9f6e32b108a5e39f7e9
parentec817fd5805b7a4d8c2f529119b74355838e4e00 [diff]
[tint][ast] Fix type <-> parameter shadowing issues.

The ZeroInitWorkgroupMemory and ModuleScopeVarToEntryPointParam transforms both suffered from issues where parameters could shadow types which are used in the function body.

To fix the ZeroInitWorkgroupMemory issue, move the workgroup zeroing logic out to a separate function.

To fix the ModuleScopeVarToEntryPointParam issue, use type inferencing on the created let declaration.

This type of issue does not exist with the IR path.

Bug: chromium:40943165
Change-Id: If1a753fddbad6a1b78b08624a038e4ab70ade0f8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/173460
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: David Neto <dneto@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: David Neto <dneto@google.com>
1048 files changed
tree: 2715a4f5686ead39b8e9e9f6e32b108a5e39f7e9
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. AUTHORS
  25. BUILD.bazel
  26. BUILD.gn
  27. CMakeLists.txt
  28. CMakeSettings.json
  29. CODE_OF_CONDUCT.md
  30. codereview.settings
  31. CONTRIBUTING.md
  32. CPPLINT.cfg
  33. DEPS
  34. DIR_METADATA
  35. go.mod
  36. go.sum
  37. go_presubmit_support.py
  38. LICENSE
  39. OWNERS
  40. PRESUBMIT.py
  41. README.chromium
  42. README.md
  43. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.