Google Git
Sign in
dawn / dawn / 9e88dffecac53821c82d6665629ecc880ad361a3
commit9e88dffecac53821c82d6665629ecc880ad361a3[log] [tgz]
authorRyan Harrison <rharrison@chromium.org>Tue Jun 17 09:54:02 2025 -0700
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jun 17 09:54:02 2025 -0700
tree2d4c13765c6e785ae489dad85a9ef4b429c88958
parent43d1c379ef751f9a68a292a53341dedac21b2bc9 [diff]
[tint][ir] Validate that discard is not directly in a non-fragment

The existing check correctly identities if a discard occurs in a
function that is called in a non-fragment entry point, but does not
catch if the function for the entry point itself contains a discard.
This is rooted to the fact that entry point functions are not considered
to be contained in any other functions, not even reflexively themselves.

This is fixed here by adding an explicit check in the validation rule
for the containing function being an endpoint. The alternate would be to
make a function be in its own set of containing functions, but that may
have wider ranging impact that would need further testing to avoid
infinite loops, since currently containing function is synonymous with
calling function.

Fixes: 424227913
Change-Id: If847c464a78db1e0ea2b90d32a2e52cdf82ac433
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/247334
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
2 files changed
tree: 2d4c13765c6e785ae489dad85a9ef4b429c88958
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-format-ignore
  20. .clang-tidy
  21. .git-blame-ignore-revs
  22. .gitattributes
  23. .gitignore
  24. .gitmodules
  25. .gn
  26. .style.yapf
  27. .vpython3
  28. AUTHORS
  29. BUILD.bazel
  30. BUILD.gn
  31. CMakeLists.txt
  32. CMakeSettings.json
  33. CODE_OF_CONDUCT.md
  34. codereview.settings
  35. CONTRIBUTING.md
  36. CPPLINT.cfg
  37. DEPS
  38. DIR_METADATA
  39. go.mod
  40. go.sum
  41. go_presubmit_support.py
  42. LICENSE
  43. OWNERS
  44. PRESUBMIT.py
  45. README.chromium
  46. README.md
  47. WATCHLISTS
  48. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.