| commit | a0ca2cc7ef6932e391168e8b21ec296ec90a6cdb | [log] [tgz] |
|---|---|---|
| author | Bryan Bernhart <bryan.bernhart@intel.com> | Thu Dec 03 10:53:04 2020 +0000 |
| committer | Corentin Wallez <cwallez@chromium.org> | Thu Dec 03 10:53:04 2020 +0000 |
| tree | 50ece2b9744faea0d7ac9c0fb605f6db5afd2b11 | |
| parent | 3668d352bc5fe13af27dc178d203f67032537a7f [diff] |
Fix WindowsDebugLogger hang on release builds Removes ASSERT checking the status of the exit handle so it cannot ever be optimized out. BUG=dawn:592 Change-Id: Ib88a058abd0597668ba3c272cf0e304f4aa19c4e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/34761 Reviewed-by: Corentin Wallez <cwallez@chromium.org>
diff --git a/src/utils/WindowsDebugLogger.cpp b/src/utils/WindowsDebugLogger.cpp index d0030e2..bcf9670 100644 --- a/src/utils/WindowsDebugLogger.cpp +++ b/src/utils/WindowsDebugLogger.cpp
@@ -89,7 +89,8 @@ } if (mShouldExitHandle != nullptr) { - ASSERT(SetEvent(mShouldExitHandle) != 0); + BOOL result = SetEvent(mShouldExitHandle); + ASSERT(result != 0); CloseHandle(mShouldExitHandle); }