Google Git
Sign in
dawn / dawn / a278ed723bd2925852f304192f7bea8f7635852c
commita278ed723bd2925852f304192f7bea8f7635852c[log] [tgz]
authorAntonio Maiorano <amaiorano@google.com>Wed Dec 04 22:14:21 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Dec 04 22:14:21 2024 +0000
tree2c1ab55aa2afb819cbc3eaf642bfe878adaf8148
parent78142958b66d46369e72622e7f96241f2c7a0ae8 [diff]
tint: fix memory leak in Command::LookPath on Windows

`Command::LookPath` calls `ExecutableExists` which uses
`MapViewOfFileEx` to check if the file is executable or not. But we were
not calling `UnmapViewOfFile` on the returned address, so this would
leak. LookPath in mainly called when looking for dxcompiler.dll, which
we only do from the tint executable and the fuzzers. As the tint exe
only processes one input at a time, we didn't notice this leak; but the
fuzzers process multiple inputs, so the leak became obvious with the
fuzzer crashing when OOM.

Bug: 381549729
Change-Id: I99f8c75844a195458c91d49928eee41a15ea0307
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/218137
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
1 file changed
tree: 2c1ab55aa2afb819cbc3eaf642bfe878adaf8148
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. AUTHORS
  26. BUILD.bazel
  27. BUILD.gn
  28. CMakeLists.txt
  29. CMakeSettings.json
  30. CODE_OF_CONDUCT.md
  31. codereview.settings
  32. CONTRIBUTING.md
  33. CPPLINT.cfg
  34. DEPS
  35. DIR_METADATA
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. WATCHLISTS
  45. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.