[dawn][common] Signal the CondVar before unlocking the mutex.

MutexCondVarProtected's guard unlocks the mutex before signaling the
condition variable. This means that usage of the condition variable
itself is not always protected by the mutex, in particular an other
thread could free the memory between mutex.unlock() and cv.signal().

Reorder the members of CondVarGuard to first notify the condition
variable and then unlock the mutex.

Adds a test that tries to catch the incorrect behavior when running
under TSan. Without the fix it reports a warning.

Fixed: 517303276
Change-Id: I373bdc4224d90b999199c58c5de0be1ba5f04c47
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/311897
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2 files changed
tree: 1af9c6ecebab65d7af78860b97385c4901bb4ee7
  1. .github/
  2. .vscode/
  3. agents/
  4. build_overrides/
  5. docs/
  6. generator/
  7. include/
  8. infra/
  9. scripts/
  10. src/
  11. test/
  12. third_party/
  13. tools/
  14. webgpu-cts/
  15. .bazelrc
  16. .bazelversion
  17. .clang-format
  18. .clang-format-ignore
  19. .clang-tidy
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. .style.yapf
  26. .vpython3
  27. AUTHORS
  28. BUILD.bazel
  29. BUILD.gn
  30. CMakeLists.txt
  31. CMakeSettings.json
  32. CODE_OF_CONDUCT.md
  33. codereview.settings
  34. CONTRIBUTING.md
  35. CPPLINT.cfg
  36. DEPS
  37. DIR_METADATA
  38. go.mod
  39. go.sum
  40. go_presubmit_support.py
  41. LICENSE
  42. MODULE.bazel
  43. MODULE.bazel.lock
  44. OWNERS
  45. PRESUBMIT.py
  46. README.chromium
  47. README.md
  48. unsafe_buffers_paths.txt
  49. WATCHLISTS
  50. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.