Google Git
Sign in
dawn / dawn / a58d8c9facbf55291dfa90edaf21a7c67cd7cc6e
commita58d8c9facbf55291dfa90edaf21a7c67cd7cc6e[log] [tgz]
authorAntonio Maiorano <amaiorano@google.com>Wed Aug 10 20:01:17 2022 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Aug 10 20:01:17 2022 +0000
tree9fe8f15d0e56dd46372c92ab18432ed57bdd5444
parent90d5eb612895d143791aa3527832fcefa57a2b99 [diff]
tint: fix builtin calls and binary ops with abstract args of different type

If a call to atan2 with args of type AFloat and AInt is made, Resolver
would correctly select the atan2(AFloat, AFloat) overload, but if the
input args were of type (AFloat, AInt), it would attempt to constant
evaluate without first converting the AInt arg to AFloat. The same would
occur for a binary operation, say AFloat + AInt. Before constant
evaluating, the Resolver now converts AInt to AFloat if necessary.

Bug: chromium:1350147
Change-Id: I85390c5d7af7e706115278ece34b2b18b8574f9f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98543
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
10 files changed
tree: 9fe8f15d0e56dd46372c92ab18432ed57bdd5444
  1. .vscode/
  2. build_overrides/
  3. docs/
  4. generator/
  5. include/
  6. infra/
  7. scripts/
  8. src/
  9. test/
  10. third_party/
  11. tools/
  12. webgpu-cts/
  13. .clang-format
  14. .clang-tidy
  15. .gitattributes
  16. .gitignore
  17. .gn
  18. AUTHORS
  19. BUILD.gn
  20. CMakeLists.txt
  21. CMakeSettings.json
  22. CODE_OF_CONDUCT.md
  23. codereview.settings
  24. CONTRIBUTING.md
  25. CPPLINT.cfg
  26. dawn.json
  27. dawn_wire.json
  28. DEPS
  29. DIR_METADATA
  30. Doxyfile
  31. go.mod
  32. go.sum
  33. LICENSE
  34. OWNERS
  35. PRESUBMIT.py
  36. README.chromium
  37. README.md
  38. tint_overrides_with_defaults.gni
README.md

Dawn's logo: a sun rising behind a stylized mountain inspired by the WebGPU logo. The text Dawn is written below it.

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the work-in-progress WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

Status

(TODO)

License

Apache 2.0 Public License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.