Make Metal and QuartzCore public dependencies of the dawn_glfw target. - By doing this, consumers can link with dawn_glfw on macOS and transitively get the right frameworks. Change-Id: I62d36ac45288a84917d1cb566d28be69f94651b2 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/198556 Commit-Queue: Jaswant Panchumarti <jaswant.panchumarti@kitware.com> Auto-Submit: Jaswant Panchumarti <jaswant.panchumarti@kitware.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
diff --git a/src/dawn/glfw/CMakeLists.txt b/src/dawn/glfw/CMakeLists.txt index b0036b9..dc3f3ad 100644 --- a/src/dawn/glfw/CMakeLists.txt +++ b/src/dawn/glfw/CMakeLists.txt
@@ -31,10 +31,11 @@ set(sources "utils.cpp" ) -set(conditional_private_depends) +set(conditional_public_depends) if (DAWN_ENABLE_METAL) list(APPEND sources "utils_metal.mm") - list(APPEND conditional_private_depends "-framework Metal") + list(APPEND conditional_public_depends "-framework Metal") + list(APPEND conditional_public_depends "-framework QuartzCore") endif () dawn_add_library( @@ -47,9 +48,9 @@ DEPENDS dawn::dawn_common dawn::dawncpp_headers + ${conditional_public_depends} PRIVATE_DEPENDS glfw - ${conditional_private_depends} ) target_compile_definitions(dawn_glfw PRIVATE "WGPU_GLFW_IMPLEMENTATION") if(BUILD_SHARED_LIBS)