Google Git
Sign in
dawn / dawn / 1c70866fbfb047ec5f606e4b06d205e8bd2e6a9e
commit1c70866fbfb047ec5f606e4b06d205e8bd2e6a9e[log] [tgz]
authorGregg Tavares <gman@chromium.org>Mon Mar 31 11:24:43 2025 -0700
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Mar 31 11:24:43 2025 -0700
tree77e3d1f4f7ba8f1147b816fe2e64b9a537cc16c9
parent66bf143b8ac648b928248d97a7dd845ae655937c [diff]
Compat: unlower limits

Because we excluded Mali-T624,T628,T720 we can make the
lower limit of maxStorageBuffersPerShaderStage be 8,
maxStorageBuffersInFragmentShaders be 4,
and maxStorageTexturesInFragmentShaders be 4

I removed 2 tests because AFAICT they are hard to fix AND, they
are tested in the CTS so they'll still be tested.

The issue is the tests were testing that, in compat, when
maxStorageTexturesInFragmentStage is less than
maxStorageTexturesPerShaderStage and you try to use
more than maxStorageTexturesInFragmentStage you get an
error. This only happens in compat because in core the
2 limits are always the max of the 2.

With the change so that maxStorageTextureInFragmentStage
is 4 it's not, by default, lower than maxStorageTexturesPerShaderStage
which is also 4.

The testing infra for the dawn_unittests doesn't appear to
have any easy way to change this. To test you'd need some way
to tell dawn to return an adapter with maxStorageTexturesPerShaderStage
greater than 4. Setting that all up seems like a waste of time given
the CTS can and does test this already.

If it is important it can be done in a different CL.

Note: tested this with a CTS that expects the new limits.
Note: this will have to wait for a CTS roll or suppressions
added to expectations.

Bug: 406729256,406729255
Fixed: 406729256,406729255
Change-Id: I9c1ddbba8d1a9e65a899ef978e3b214ae6affd28
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/233398
Commit-Queue: Gregg Tavares <gman@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
4 files changed
tree: 77e3d1f4f7ba8f1147b816fe2e64b9a537cc16c9
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. AUTHORS
  26. BUILD.bazel
  27. BUILD.gn
  28. CMakeLists.txt
  29. CMakeSettings.json
  30. CODE_OF_CONDUCT.md
  31. codereview.settings
  32. CONTRIBUTING.md
  33. CPPLINT.cfg
  34. DEPS
  35. DIR_METADATA
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. WATCHLISTS
  45. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.