Google Git
Sign in
dawn / dawn / aebc7be46ec601333832bc14256242f3280bbbd1
commitaebc7be46ec601333832bc14256242f3280bbbd1[log] [tgz]
authorCorentin Wallez <cwallez@chromium.org>Fri Sep 20 13:11:56 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Sep 20 13:11:56 2024 +0000
tree9546659a438c35989ff5847bade520508bed1ff9
parentf4340f83b2e522102f4b4038b2ac096eef24f130 [diff]
dawn::native: Fix the check for no attachment pipelines.

The check for attachments being required for render pipelines was
incorrect because it was only performed if desc->fragment != nullptr,
which is incorrect because desc->fragment == nullptr means that there is
no color attachment, and is an error if there's no depthStencil state.

Adds a regression test.
Fixes unittests that were triggering this validation by mistake, and
sent a CTS PR for the same purpose.

Bug: 341812551
Change-Id: I1daf726e258712535a42451323c84349257aefe4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/204934
Reviewed-by: Jiawei Shao <jiawei.shao@intel.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
5 files changed
tree: 9546659a438c35989ff5847bade520508bed1ff9
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. AUTHORS
  25. BUILD.bazel
  26. BUILD.gn
  27. CMakeLists.txt
  28. CMakeSettings.json
  29. CODE_OF_CONDUCT.md
  30. codereview.settings
  31. CONTRIBUTING.md
  32. CPPLINT.cfg
  33. DEPS
  34. DIR_METADATA
  35. go.mod
  36. go.sum
  37. go_presubmit_support.py
  38. LICENSE
  39. OWNERS
  40. PRESUBMIT.py
  41. README.chromium
  42. README.md
  43. WATCHLISTS
  44. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.