Google Git
Sign in
dawn / dawn / aed92a6ec9c4f63c389a053c7b923aa291045318
commitaed92a6ec9c4f63c389a053c7b923aa291045318[log] [tgz]
authordan sinclair <dsinclair@chromium.org>Wed Feb 21 14:24:16 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Feb 21 14:24:16 2024 +0000
tree1d4805b181bf5901e68b74df6780205a17b9f063
parent6e86456bbd827e6eea77acc7824cd82daf070436 [diff]
[msl] Fix issue with module scoped private var and modf.

In the MSL backend we convert private module scoped variables into a
structure which is create in the entry point and pased around. The
private variables are initialized if they are transitively used from the
entry point.

If the private is initialized with a `modf` then we have an implicit
internal structure which is created. This structure doesn't exist in the
AST, it's synthesized by the AST printer. If we've removed the private
variable usage, then we currently end up with a refernece ot the modf
structure in the privates structure but we never emit the modf structure
as we never emit the modf.

This CL updates the AST printer to always attempt to emit the structure
then we emiting the `type` of the structure. The structures themselves
are check and only emitted once. This forces the modf structure to be
emitted as needed.

Bug: tint:2069
Change-Id: I168e174b8fd530974bb050d1013be602422d189f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/175521
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
11 files changed
tree: 1d4805b181bf5901e68b74df6780205a17b9f063
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. AUTHORS
  25. BUILD.bazel
  26. BUILD.gn
  27. CMakeLists.txt
  28. CMakeSettings.json
  29. CODE_OF_CONDUCT.md
  30. codereview.settings
  31. CONTRIBUTING.md
  32. CPPLINT.cfg
  33. DEPS
  34. DIR_METADATA
  35. go.mod
  36. go.sum
  37. go_presubmit_support.py
  38. LICENSE
  39. OWNERS
  40. PRESUBMIT.py
  41. README.chromium
  42. README.md
  43. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.