commit b033c9da8e163f9eea0e7283191971a2b8975796
author Ryan Harrison <rharrison@chromium.org> Wed Jan 27 22:15:14 2021 +0000
committer Commit Bot service account <commit-bot@chromium.org> Wed Jan 27 22:15:14 2021 +0000
tree 3607d89fbbfbd0a60c9d4d29b6801253b802fd17
parent aae37c2ea3a93bcac0b62ce8d470840d57c1fa82

Enable tests in GpuMemorySynchronizationTests.cpp

The blocking issues in Tint for the tests in this file have been
resolved, so they can be re-enabled.

There is one outstanding TODO related to Tint in the file about
re-writting one of the shaders, which the root issue for is still
open.

BUG=tint:398

Change-Id: Ia173a33d7ea88b6355dff8b02fd8394f2fa61fd7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/39120
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>

src/tests/end2end/GpuMemorySynchronizationTests.cpp

diff --git a/src/tests/end2end/GpuMemorySynchronizationTests.cpp b/src/tests/end2end/GpuMemorySynchronizationTests.cpp
index 30b9c46..ffdc643 100644
--- a/src/tests/end2end/GpuMemorySynchronizationTests.cpp
+++ b/src/tests/end2end/GpuMemorySynchronizationTests.cpp
@@ -21,13 +21,6 @@
 
 class GpuMemorySyncTests : public DawnTest {
   protected:
-    void SetUp() override {
-        DawnTest::SetUp();
-
-        // TODO(crbug.com/tint/398): GLSL builtins don't work with SPIR-V reader.
-        DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator"));
-    }
-
     wgpu::Buffer CreateBuffer() {
         wgpu::BufferDescriptor srcDesc;
         srcDesc.size = 4;
@@ -308,13 +301,6 @@
 
 class StorageToUniformSyncTests : public DawnTest {
   protected:
-    void SetUp() override {
-        DawnTest::SetUp();
-
-        // TODO(crbug.com/tint/398): GLSL builtins don't work with SPIR-V reader.
-        DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator"));
-    }
-
     void CreateBuffer() {
         wgpu::BufferDescriptor bufferDesc;
         bufferDesc.size = sizeof(float);