Google Git
Sign in
dawn / dawn / b7d43415b1ef5b9a6b3c26b74af5537684dbcbe0
commitb7d43415b1ef5b9a6b3c26b74af5537684dbcbe0[log] [tgz]
authorAntonio Maiorano <amaiorano@google.com>Wed Nov 27 20:26:05 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Nov 27 20:26:05 2024 +0000
tree65ba636817f2de47b207e5e291e65b7ea86911fa
parenta50b2e52046756d6a9fd3df4954ceed582f63cba [diff]
dawn/hlsl: revert dumping HLSL if compilation fails

This CL effectively reverts https://dawn-review.googlesource.com/c/dawn/+/130460
Unfortunately, this change never actually worked since if
`d3d::CompileShader` fails to compile, the output `compiledShader` would
remain invalid, so attempting to dump its contents would not work.
Furthermore, we would actually crash the GPU process because we were
dereferencing `compiledShader` when it was still invalid.

This CL reverts the original change, so if compilation fails, we don't
crash, and we output the compilation error without dumping HLSL. I will
follow up with a working implementation.

Bug: 42240637
Bug: 381065163
Change-Id: I8d10980863f746bc886e3af4d1b0b26dfdb9671a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/216994
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
4 files changed
tree: 65ba636817f2de47b207e5e291e65b7ea86911fa
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. AUTHORS
  26. BUILD.bazel
  27. BUILD.gn
  28. CMakeLists.txt
  29. CMakeSettings.json
  30. CODE_OF_CONDUCT.md
  31. codereview.settings
  32. CONTRIBUTING.md
  33. CPPLINT.cfg
  34. DEPS
  35. DIR_METADATA
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. WATCHLISTS
  45. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.