Google Git
Sign in
dawn / dawn / b8e5a6adcd7da6e9c5612783eae1d802bd6a400f
commitb8e5a6adcd7da6e9c5612783eae1d802bd6a400f[log] [tgz]
authorSunny Sachanandani <sunnyps@chromium.org>Wed Nov 15 16:20:13 2023 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Nov 15 16:20:13 2023 +0000
tree8ff20345f229643601a04b6e9e1405d29327007d
parent5896e7501bf3a0dccb12f146949195d461d4a71e [diff]
Fix webgpu_dawn_native_proc multiple paths build issue

Recent ninja versions complain if multiple rules generate the same
target within a single build. This happens when Dawn native is built in
Skia:

% autoninja -C out/Default dm
ninja: Entering directory `out/Default'
ninja: error: obj/third_party/externals/dawn/src/dawn/native/webgpu_dawn_static.ninja:12: multiple rules generate obj/BUILD_DIR/gen/third_party/externals/dawn/src/dawn/native/libwebgpu_dawn.webgpu_dawn_native_proc.o

This is because the webgpu_native_proc_gen output sources are included
in both the static and shared lib variants of webgpu_dawn:

% gn refs out/Default third_party/externals/dawn/src/dawn/native:webgpu_dawn_native_proc_gen
//third_party/externals/dawn/src/dawn/native:webgpu_dawn_shared
//third_party/externals/dawn/src/dawn/native:webgpu_dawn_static

webgpu_dawn is a dawn_component that directly includes target outputs
of webgpu_dawn_native_proc_gen in its sources. One way of fixing this is
to introduce an intermediate source_set that contains target outputs of
webgpu_dawn_native_proc_gen which is what this CL does.

Change-Id: I1e78ad5815ee8710053e30e7f9368c886d38278b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/160641
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org>
2 files changed
tree: 8ff20345f229643601a04b6e9e1405d29327007d
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. AUTHORS
  25. BUILD.bazel
  26. BUILD.gn
  27. CMakeLists.txt
  28. CMakeSettings.json
  29. CODE_OF_CONDUCT.md
  30. codereview.settings
  31. CONTRIBUTING.md
  32. CPPLINT.cfg
  33. dawn.json
  34. dawn_wire.json
  35. DEPS
  36. DIR_METADATA
  37. Doxyfile
  38. go.mod
  39. go.sum
  40. go_presubmit_support.py
  41. LICENSE
  42. OWNERS
  43. PRESUBMIT.py
  44. README.chromium
  45. README.md
  46. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.