[spirv-reader][ir] Remove invalid test This test is no longer valid per the updated SPIR-V rules. The old parser had special logic to handle invalid SPIR-V. The IR reader requires valid SPIR-V. Bug: 398890649 Change-Id: Ief245222ed64b9e6554bca8674b21aef81f3c55e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/230720 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: James Price <jrprice@google.com>
diff --git a/src/tint/lang/spirv/reader/parser/branch_test.cc b/src/tint/lang/spirv/reader/parser/branch_test.cc index 095dcc9..ae58b8f 100644 --- a/src/tint/lang/spirv/reader/parser/branch_test.cc +++ b/src/tint/lang/spirv/reader/parser/branch_test.cc
@@ -6824,68 +6824,5 @@ )"); } -// crbug.com/tint/524 -// -// Fails spirv validation? -// spirv:1:1 error: Selection must be structured -// OpBranchConditional %true %30 %40 -TEST_F(SpirvParserTest, DISABLED_LoopInternallyDiverge_Simple) { - EXPECT_IR(R"( - OpCapability Shader - OpMemoryModel Logical GLSL450 - OpEntryPoint GLCompute %main "main" - OpExecutionMode %main LocalSize 1 1 1 - %void = OpTypeVoid - %i32 = OpTypeInt 32 1 - %bool = OpTypeBool - %one = OpConstant %i32 1 - %two = OpConstant %i32 2 - %three = OpConstant %i32 3 - %true = OpConstantTrue %bool - %ep_type = OpTypeFunction %void - %main = OpFunction %void None %ep_type - %10 = OpLabel - %34 = OpIAdd %i32 %one %one - OpBranch %20 - %20 = OpLabel - %35 = OpIAdd %i32 %two %two - OpLoopMerge %99 %90 None - OpBranchConditional %true %30 %40 ; divergence - %30 = OpLabel - %36 = OpIAdd %i32 %three %three - OpBranch %90 - %40 = OpLabel - %37 = OpIAdd %i32 %one %two - OpBranch %90 - %90 = OpLabel ; continue target - %38 = OpIAdd %i32 %one %three - OpBranch %20 - %99 = OpLabel ; loop merge - %39 = OpIAdd %i32 %two %one - OpReturn - OpFunctionEnd -)", - R"( - -)"); - - // auto* expect = R"(var_1 = 10u; - // loop { - // var_1 = 20u; - // if (false) { - // var_1 = 30u; - // continue; - // } else { - // var_1 = 40u; - // } - // - // continuing { - // var_1 = 90u; - // } - // } - // var_1 = 99u; - // return; -} - } // namespace } // namespace tint::spirv::reader