tools/cts: Treat 'Skip' results as 'Pass'
Change-Id: I2548c2449e535cff1f6907a9f2e892037038aa02
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95841
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
diff --git a/tools/src/cts/expectations/update.go b/tools/src/cts/expectations/update.go
index a494551..fb095ae 100644
--- a/tools/src/cts/expectations/update.go
+++ b/tools/src/cts/expectations/update.go
@@ -78,13 +78,17 @@
tagSets []result.Tags // reverse-ordered tag-sets of 'in'
}
-// simplifyStatuses replaces all result statuses that are not 'Pass',
-// 'RetryOnFailure', 'Slow', 'Skip' with 'Failure'.
+// simplifyStatuses replaces all result statuses that are not one of
+// 'Pass', 'RetryOnFailure', 'Slow', 'Skip' with 'Failure', and also replaces
+// 'Skip' results with 'Pass'.
func simplifyStatuses(results result.List) {
for i, r := range results {
switch r.Status {
- case result.Pass, result.RetryOnFailure, result.Slow, result.Skip:
+ case result.Pass, result.RetryOnFailure, result.Slow:
// keep
+ case result.Skip:
+ // Typically represents a .unimplemented() test
+ results[i].Status = result.Pass
default:
results[i].Status = result.Failure
}
