Google Git
Sign in
dawn/dawn/bf5a1770a9e170848194a3cfacd293045fbfb280
commit
bf5a1770a9e170848194a3cfacd293045fbfb280
[log]
author
Ryan Harrison <rharrison@chromium.org>
Thu May 14 16:03:36 2026 -0700
committer
dawn-scoped@luci-project-accounts.iam.gserviceaccount.com <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>
Thu May 14 16:03:36 2026 -0700
tree
c1fab2fb922eacc7b738f54d3e42484f3a719b85
parent
1147935a18b4dc9509d180621486ba78474f0c6b [diff]
[val] Fix task ordering for instructions with nested blocks

The main issue being addressed here is the ordering of control
instructions are processed.

As-is it is possible for results of the instruction to processed
before the nested block, which means that nested blocks referencing
the results will silently succeed, because it appears that the
definition is occurring first.

Since the tasks are processed via a stack, moving to pushing the
results before the blocks to correct the ordering.

This fix exposed another ordering issue, this time with CheckRootBlock
that needed to be addressed.

Fixes: 511299711
Change-Id: I3a526483da3eb19fe988404d333890e64fece3dc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/308935
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: James Price <jrprice@google.com>
2 files changed
tree: c1fab2fb922eacc7b738f54d3e42484f3a719b85
  1. .github/
  2. .vscode/
  3. agents/
  4. build_overrides/
  5. docs/
  6. generator/
  7. include/
  8. infra/
  9. scripts/
  10. src/
  11. test/
  12. third_party/
  13. tools/
  14. webgpu-cts/
  15. build
  16. buildtools
  17. testing
  18. .bazelrc
  19. .clang-format
  20. .clang-format-ignore
  21. .clang-tidy
  22. .git-blame-ignore-revs
  23. .gitattributes
  24. .gitignore
  25. .gitmodules
  26. .gn
  27. .style.yapf
  28. .vpython3
  29. AUTHORS
  30. BUILD.bazel
  31. BUILD.gn
  32. CMakeLists.txt
  33. CMakeSettings.json
  34. CODE_OF_CONDUCT.md
  35. codereview.settings
  36. CONTRIBUTING.md
  37. CPPLINT.cfg
  38. DEPS
  39. DIR_METADATA
  40. go.mod
  41. go.sum
  42. go_presubmit_support.py
  43. LICENSE
  44. OWNERS
  45. PRESUBMIT.py
  46. README.chromium
  47. README.md
  48. unsafe_buffers_paths.txt
  49. WATCHLISTS
  50. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.