Google Git
Sign in
dawn / dawn / afc9c139de7ea3a911171da83ac6922a0089fe34
commitafc9c139de7ea3a911171da83ac6922a0089fe34[log] [tgz]
authorJiawei Shao <jiawei.shao@intel.com>Sun Dec 15 20:53:11 2024 -0800
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Sun Dec 15 20:53:11 2024 -0800
treed76c466d4f4cd5da5cbc2ef42fd89b454bcc6134
parentad54e957a81258f0bec879e1ff6fde0272f70099 [diff]
D3D12: Hard-enable `D3D12SplitBufferTextureCopyForRowsPerImagePaddings`

The toggle `D3D12SplitBufferTextureCopyForRowsPerImagePaddings` doesn't
need to be defined as the code path it controlled before should always
be executed. It is because:
1. In D3D12, the concept of `bufferLocation` specifies how to treat a
   region of a buffer as a texture. In buffer-texture copies
   `rowsPerImage` is used as the height of the `bufferLocation`, so if
   the buffer is not large enough to hold a complete `rowsPerImage`
   D3D12 debug layer will generate an error that the buffer is not large
   enough to hold a complete `bufferLocation`, which fully meets the
   concept in D3D12 and cannot say it a `bug` of D3D12 runtime.
2. Although `UnrestrictedBufferTextureCopyPitchSupported` has been used
   in Dawn we still need to split a buffer-texture copy into two in
   some certain situations because of (1).

Bug: 42240278
Change-Id: I83981d92057b79661aa39ede66a611329b7cf8a4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/218915
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
5 files changed
tree: d76c466d4f4cd5da5cbc2ef42fd89b454bcc6134
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. AUTHORS
  26. BUILD.bazel
  27. BUILD.gn
  28. CMakeLists.txt
  29. CMakeSettings.json
  30. CODE_OF_CONDUCT.md
  31. codereview.settings
  32. CONTRIBUTING.md
  33. CPPLINT.cfg
  34. DEPS
  35. DIR_METADATA
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. WATCHLISTS
  45. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.