Google Git
Sign in
dawn / dawn / d9ca1a8b1a64c83775ceb4f9274f209b7c86a491
commitd9ca1a8b1a64c83775ceb4f9274f209b7c86a491[log] [tgz]
authorJames Price <jrprice@google.com>Tue May 07 00:10:51 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 07 00:10:51 2024 +0000
treeed306033b37c58186d89956af8c8e614e4b71ee8
parent6be95cec0b75d0d08cba9b56f56d4ed4ee5ee64e [diff]
[uniformity] Fix ICE for pointer parameters

The code for determining the source of uniformity was assuming that a
parameter node was always visited directly from an identifier
expression node. This is not the case when there is control flow
before the identifier expression that introduces additional nodes for
merging values. Add extra metadata to parameter nodes so that we can
correctly emit their source info instead.

This also slightly improves error messages for pointer parameters.

Fixed: 42251307
Change-Id: I4a3fed2c5f9c177c0b227a8354fd1564599c8d0a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/186540
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: James Price <jrprice@google.com>
Auto-Submit: James Price <jrprice@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
2 files changed
tree: ed306033b37c58186d89956af8c8e614e4b71ee8
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. AUTHORS
  25. BUILD.bazel
  26. BUILD.gn
  27. CMakeLists.txt
  28. CMakeSettings.json
  29. CODE_OF_CONDUCT.md
  30. codereview.settings
  31. CONTRIBUTING.md
  32. CPPLINT.cfg
  33. DEPS
  34. DIR_METADATA
  35. go.mod
  36. go.sum
  37. go_presubmit_support.py
  38. LICENSE
  39. OWNERS
  40. PRESUBMIT.py
  41. README.chromium
  42. README.md
  43. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.