Google Git
Sign in
dawn / dawn / 5f85f4f5c9d27cdeaee9e01c572784908ff676f0
commit5f85f4f5c9d27cdeaee9e01c572784908ff676f0[log] [tgz]
authorRyan Harrison <rharrison@chromium.org>Mon Aug 18 14:04:16 2025 -0700
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Aug 18 14:04:16 2025 -0700
treed3014398d085fe779b7f19b6b71e6690ce290d57
parent1455a56bf76540305a81a0b95300cd7fefd9b036 [diff]
Cleanup lint issues with uses of testify in Go code

Ran testifylint (https://github.com/Antonboom/testifylint) over our
tests to see what issues it would detect, since testify has some
inconsistent APIs, e.g. .Equal(expect, real), but .Len(obj, count), so
it is easy to get args reversed or miss a better function to use.

It found mostly minor things, like being able use .Len() instead of
.Equal(..., len(foo)) or using .NoError() instead of .Nil() on errors,
and a bunch of .Equal() calls that should be reversed.

It did get a number of things wrong that I had to revert, and missed a
number potential cleanups (like specific cases it could be using
.NoError() or .Len() even though it identified other cases in the same
file), so I don't think I would recommend us adding it to our
presubmit or CI.

It is a useful tool for checking your code style, but I don't think it
is good enough at this point to be blocking CLs or be run in an
automated fashion.

Change-Id: Ib44412442af82cf3ab3bf04de7c4d68fabb1f2ca
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/257896
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@google.com>
Commit-Queue: Brian Sheedy <bsheedy@google.com>
11 files changed
tree: d3014398d085fe779b7f19b6b71e6690ce290d57
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-format-ignore
  20. .clang-tidy
  21. .git-blame-ignore-revs
  22. .gitattributes
  23. .gitignore
  24. .gitmodules
  25. .gn
  26. .style.yapf
  27. .vpython3
  28. AUTHORS
  29. BUILD.bazel
  30. BUILD.gn
  31. CMakeLists.txt
  32. CMakeSettings.json
  33. CODE_OF_CONDUCT.md
  34. codereview.settings
  35. CONTRIBUTING.md
  36. CPPLINT.cfg
  37. DEPS
  38. DIR_METADATA
  39. go.mod
  40. go.sum
  41. go_presubmit_support.py
  42. LICENSE
  43. OWNERS
  44. PRESUBMIT.py
  45. README.chromium
  46. README.md
  47. WATCHLISTS
  48. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.